mgr/dashboard: Prevent table items from getting selected while expanding

[nizamial09]

While clicking on the expand button inside a table, the entire row is getting selected. This commit prevent that from happening.

Fixes: https://tracker.ceph.com/issues/47376
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[tspmelo]

Please add a new unit test to check if the selection is not changed when expanding a different row.

[epuertat]

Once addressed @tspmelo's comments, I'm ok with this PR! Thanks @nizamial09!

[nizamial09]

Please add a new unit test to check if the selection is not changed when expanding a different row.

Added the unit test. Please take a look, thanks. @tspmelo

Just a suggestion, can you also update the gif in PR description which covers this test?

[avanthakkar]

Tested it locally, LGTM!

[nizamial09]

@avanthakkar Just saw your suggestion. The suggestion was edited into my comment so I missed it before. Anyway I've updated the description with the new gif. Thanks

[avanthakkar]

@avanthakkar Just saw your suggestion. The suggestion was edited into my comment so I missed it before. Anyway I've updated the description with the new gif. Thanks

Yeah, I just saw that, my mistake. Thanks!

[votdev]

I think you should check if e2e test aren't broken by this PR.

  Configuration page
    breadcrumb test
      ✓ should open and show breadcrumb (2709ms)
    fields check
      1) should verify that selected footer increases when an entry is clicked
      ✓ should check that details table opens (w/o tab header) (1077ms)
    edit configuration test
      ✓ should click and edit a configuration and results should appear in the table (9299ms)
      ✓ should show only modified configurations (1439ms)
      ✓ should hide all modified configurations (1457ms)


  5 passing (27s)
  1 failing

  1) Configuration page
       fields check
         should verify that selected footer increases when an entry is clicked:
     AssertionError: expected 0 to equal 1
      at Context.eval (https://bionic-huge--734e7c1f-b7d8-454f-a114-e1abf5a3d023:41140/__cypress/tests?p=cypress/integration/cluster/configuration.e2e-spec.ts:21:53)

[nizamial09]

I think you should check if e2e test aren't broken by this PR.

  Configuration page
    breadcrumb test
      ✓ should open and show breadcrumb (2709ms)
    fields check
      1) should verify that selected footer increases when an entry is clicked
      ✓ should check that details table opens (w/o tab header) (1077ms)
    edit configuration test
      ✓ should click and edit a configuration and results should appear in the table (9299ms)
      ✓ should show only modified configurations (1439ms)
      ✓ should hide all modified configurations (1457ms)


  5 passing (27s)
  1 failing

  1) Configuration page
       fields check
         should verify that selected footer increases when an entry is clicked:
     AssertionError: expected 0 to equal 1
      at Context.eval (https://bionic-huge--734e7c1f-b7d8-454f-a114-e1abf5a3d023:41140/__cypress/tests?p=cypress/integration/cluster/configuration.e2e-spec.ts:21:53)

Oh yeah, thanks. Let me check this locally.

[nizamial09]

jenkins test dashboard

[nizamial09]

jenkins test dashboard

[nizamial09]

jenkins test make check

[nizamial09]

@votdev I removed certain lines from the e2e files like should verify that selected footer increases when an entry is clicked. IMO this feels like a unit test and similar unit test is already covered in this PR (row getting selected).