test/mon: FreeBSD returns ENOENT on resolv error#38026
Merged
tchaikov merged 1 commit intoceph:masterfrom Nov 15, 2020
Merged
Conversation
wjwithagen
added
bug-fix
FreeBSD
batrick
approved these changes
Nov 11, 2020
tchaikov
requested changes
Nov 12, 2020
Contributor
tchaikov
left a comment
tchaikov
left a comment
There was a problem hiding this comment.
could you please use
test/mon: return ENOENT on resolv error on FreeBSD
as the title of the commit message?
wjwithagen
changed the title
wjwithagen
force-pushed
the
wjw-fix-test-mon-build_initial
branch
from
323a432 to
8ad8b1d
Compare
Contributor
|
@wjwithagen i still don't like the title, which claims that "FreeBSD returns ENOENT". this is a fact, not the change you made in this patch. so could you put it in the body of the commit message, as the reason why we need your change? and use
as the title instead? |
FreeBSD returns ENOENT on resolv error Tracker: https://tracker.ceph.com/issues/48183 Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
wjwithagen
force-pushed
the
wjw-fix-test-mon-build_initial
branch
from
8ad8b1d to
5ae4827
Compare
Contributor
Author
|
@tchaikov |
tchaikov
approved these changes
Nov 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracker: https://tracker.ceph.com/issues/48183
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox