ceph-volume: add some flexibility to bytes_to_extents#38687
Merged
jan--f merged 2 commits intoceph:masterfrom Feb 3, 2021
Merged
ceph-volume: add some flexibility to bytes_to_extents#38687jan--f merged 2 commits intoceph:masterfrom
jan--f merged 2 commits intoceph:masterfrom
Conversation
jan--f
force-pushed
the
c-v-lv-size-request-too-big
branch
from
2de05d6 to
50a3671
Compare
added 2 commits
December 22, 2020 16:03
For batch we want to report the projected sizes before creating any LVM structures, we use the device size for that. This means we pass this projected size to lvm/api.py::create_lv. This could result in situations where we request more extents for the new LV than are actually available, as LVM takes up some available space on the block device (plus alignment). We fix this by adjusting the extent count downwards if its less than 1% off the requested value. Fixes: https://tracker.ceph.com/issues/47758 Signed-off-by: Jan Fajerski <jfajerski@suse.com>
The real things uses string properties as well. Signed-off-by: Jan Fajerski <jfajerski@suse.com>
jan--f
force-pushed
the
c-v-lv-size-request-too-big
branch
from
50a3671 to
c4bbb1b
Compare
Contributor
Author
|
jenkins test ceph-volume all |
Contributor
Author
|
jenkins test ceph-volume tox |
|
I really need this to be able to use the SSDs in my cluster. Any thoughts on when this will be released, if ever? |
Contributor
Author
Yes, we need at least a review on this though. @jmolmo @guits @rishabh-d-dave ? |
|
I have used the same fixes in my setup here where I pass through physical
spinning disks in oVirt to the virtual machines in order to have the OSDs
virtualized. Thanks for putting in the work Jan.
…On Thu, Jan 21, 2021 at 7:20 AM Jan Fajerski ***@***.***> wrote:
I really need this to be able to use the SSDs in my cluster. Any thoughts
on when this will be released, if ever?
Yes, we need at least a review on this though. @jmolmo
<https://github.com/jmolmo> @guits <https://github.com/guits>
@rishabh-d-dave <https://github.com/rishabh-d-dave> ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38687 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGKXNU6ZJ3667BPL5CAGSZ3S3ASZLANCNFSM4VFVQ6PA>
.
|
Contributor
Author
ping again. I no one willing to review this? |
|
Yes, could we please get a review on this!
…On Fri, Jan 29, 2021 at 5:32 AM Jan Fajerski ***@***.***> wrote:
I really need this to be able to use the SSDs in my cluster. Any thoughts
on when this will be released, if ever?
Yes, we need at least a review on this though. @jmolmo
<https://github.com/jmolmo> @guits <https://github.com/guits>
@rishabh-d-dave <https://github.com/rishabh-d-dave> ?
ping again. I no one willing to review this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38687 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABO2Q4YST5UM7OFS6HAWF3LS4KTFNANCNFSM4VFVQ6PA>
.
|
jmolmo
approved these changes
Feb 2, 2021
Member
|
|
Awesome! Thanks for the approval! Time to get some SSDs in my cluster!
…On Tue, Feb 2, 2021 at 8:53 AM Juan Miguel Olmo ***@***.***> wrote:
Reopened #38687 <#38687>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38687 (comment)>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABO2Q45YZKCBEBFQIIUCH2LS5ANX3ANCNFSM4VFVQ6PA>
.
|
|
@jan--f looks like this is failing some tests |
Contributor
Author
That's just an intermittent infrastructure issue. |
This was referenced Feb 3, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For batch we want to report the projected sizes before creating any LVM
structures, we use the device size for that. This means we pass this
projected size to lvm/api.py::create_lv. This could result in situations
where we request more extents for the new LV than are actually
available, as LVM takes up some available space on the block device
(plus alignment).
We fix this by adjusting the extent count downwards if its less than 1% off the
requested value.
Fixes: https://tracker.ceph.com/issues/47758
Signed-off-by: Jan Fajerski jfajerski@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox