mgr/dashboard: filesystem pool size should use stored stat#40874
Merged
tchaikov merged 1 commit intoceph:masterfrom Apr 19, 2021
Merged
mgr/dashboard: filesystem pool size should use stored stat#40874tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
avanthakkar
requested review from
a team,
aaSharma14,
alfonsomthd and
callithea
and removed request for
a team
Fixes: https://tracker.ceph.com/issues/50195 Signed-off-by: Avan Thakkar <athakkar@redhat.com> Replaces 'bytes_used' with 'stored' stat to see the correct results of CephFS pool stats.
avanthakkar
force-pushed
the
fix-cephfs-pool-size-stat
branch
from
fb377a4 to
7110fd4
Compare
aaSharma14
approved these changes
Apr 15, 2021
Contributor
Author
|
@alfonsomthd I think no additional unit-test will be required here, as this line already checks for the change ceph/qa/tasks/mgr/dashboard/test_cephfs.py Line 167 in 3903a71 pool_used = stats['stored']) and tests are passing so isn't that enough? Or were you referring to something else?
|
This was referenced Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces 'bytes_used' with 'stored' stat to see the correct results of CephFS pool stats.
Fixes: https://tracker.ceph.com/issues/50195
Signed-off-by: Avan Thakkar athakkar@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox