Skip to content

mgr/cephadm: skip ok-to-stop for mds in upgrade if not enough mds daemons#41346

Merged
sebastian-philipp merged 2 commits intoceph:masterfrom
adk3798:enough-mds-upgrade
Jun 16, 2021
Merged

mgr/cephadm: skip ok-to-stop for mds in upgrade if not enough mds daemons#41346
sebastian-philipp merged 2 commits intoceph:masterfrom
adk3798:enough-mds-upgrade

Conversation

@adk3798
Copy link
Copy Markdown
Contributor

@adk3798 adk3798 commented May 14, 2021

Fixes: https://tracker.ceph.com/issues/50817

Signed-off-by: Adam King adking@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@adk3798 adk3798 requested a review from a team as a code owner May 14, 2021 18:06
Copy link
Copy Markdown
Contributor

@mgfritch mgfritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this works since a . char is valid within an fs_name

for example:

$ ceph fs volume create a.b.c

@adk3798 adk3798 force-pushed the enough-mds-upgrade branch 2 times, most recently from c5bedbf to 0e24ae3 Compare May 17, 2021 16:45
@adk3798
Copy link
Copy Markdown
Contributor Author

adk3798 commented May 17, 2021

I'm not sure this works since a . char is valid within an fs_name

for example:

$ ceph fs volume create a.b.c

This now uses mds_daemon.service_name().split('.', 1)[1] to match the mds daemon to its fs. Since the service name we store is always mds.<fs-name> I think it should work regardless of the number of "." characters in the fs name or hostname of the host the daemon is on. Now also using Cephadm's HostCache to get the number of daemons rather than the mds metadata since it's too difficult to match the mds daemons in the metadata to the correct fs.

@mgfritch
Copy link
Copy Markdown
Contributor

jenkins test make check

@adk3798 adk3798 force-pushed the enough-mds-upgrade branch from 0e24ae3 to 2bfc4bd Compare May 25, 2021 13:39
@sebastian-philipp sebastian-philipp added the wip-swagner-testing My Teuthology tests label Jun 15, 2021
@sebastian-philipp
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants