mgr/cephadm: skip ok-to-stop for mds in upgrade if not enough mds daemons#41346
Merged
sebastian-philipp merged 2 commits intoceph:masterfrom Jun 16, 2021
Merged
mgr/cephadm: skip ok-to-stop for mds in upgrade if not enough mds daemons#41346sebastian-philipp merged 2 commits intoceph:masterfrom
sebastian-philipp merged 2 commits intoceph:masterfrom
Conversation
mgfritch
reviewed
May 14, 2021
Contributor
mgfritch
left a comment
There was a problem hiding this comment.
I'm not sure this works since a . char is valid within an fs_name
for example:
$ ceph fs volume create a.b.c
c5bedbf to
0e24ae3
Compare
Contributor
Author
This now uses |
mgfritch
approved these changes
May 24, 2021
Contributor
|
jenkins test make check |
Signed-off-by: Adam King <adking@redhat.com>
…mons Fixes: https://tracker.ceph.com/issues/50817 Signed-off-by: Adam King <adking@redhat.com>
0e24ae3 to
2bfc4bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/50817
Signed-off-by: Adam King adking@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox