ceph.spec.in, debian/rules: enable rbd-rwl-cache by default only on x86_64 by kevinzs2048 · Pull Request #41998 · ceph/ceph

kevinzs2048 · 2021-06-24T01:29:04Z

set rwl cache option on arm64 as PMDK is not well supported

Currently, PMDK is not well supported on Arm64. The PMDK make check can not pass, and librpmem(remote persist memory lib) is not enabled on Arm64.
So in Ceph we can make it optional and wait for PMDK changes on Arm64

Tracker Link: https://tracker.ceph.com/issues/51339

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox

tchaikov · 2021-06-24T01:45:06Z

@kevinzs2048 could you remove "pacific: " from the title of the commit message. and add

Fixes: https://tracker.ceph.com/issues/51339

right before your Signed-off-by line. please see the output of git log for more examples. also, would be be great to accompany some references explaining why

Currently, PMDK is not well supported on Arm64.

in the commit message.

kevinzs2048 · 2021-06-24T02:23:10Z

@tchaikov Thanks for the comments. Done

tchaikov · 2021-06-24T02:51:51Z

jenkins test make check

idryomov · 2021-06-24T11:24:46Z

ceph.spec.in

+%elifarch aarch64
+%bcond_without lttng
+%bcond_with rbd_rwl_cache
+%bcond_without rbd_ssd_cache


No problem with disabling the rwl mode by default on aarch64, but I don't understand why the ssd mode gets special treatment in the spec file. IIRC it doesn't depend on PMDK or any other libraries, so I think should be enabled by default regardless of the architecture and distribution.

@idryomov #42006 is created to address this issue.

i will rebase this PR once #42006 gets merged (if it is approved).

I approved #42006. For this PR, I think we should move rbd_rwl_cache manipulation to the top level because the architectures that it is supported on (x86_64 ppc64le) are the same for Fedora/RHEL and SUSE.

@idryomov agreed.

@kevinzs2048 could you rebase on top of my change and address Ilya's comment?

Thanks for the review. @idryomov @tchaikov
Done.
Disable ppc64 as well as PMDK is only official support on x86

idryomov · 2021-06-24T11:26:43Z

@tchaikov Do you see a problem with a single %bcond_without rbd_ssd_cache line at the top level replacing all existing instances?

unlike rbd_rwl_cache, rbd_ssd_cache does not depend on pmdk (libpmem), so let's enable it on all supported architecture and rpm based distros. Signed-off-by: Kefu Chai <kchai@redhat.com>

dismissed.

idryomov · 2021-06-24T12:26:25Z

@tchaikov What about deb packages? I see unconditional

extraopts += -DWITH_RBD_RWL=ON

in debian/rules, am I missing something or do we only care about amd64 there?

tchaikov · 2021-06-24T12:28:53Z

@tchaikov What about deb packages? I see unconditional
extraopts += -DWITH_RBD_RWL=ON
in debian/rules, am I missing something or do we only care about amd64 there?

ahh, right! we should conditionalize WITH_RBD_RWL in debian/rules as well.

…pc64le set rwl cache option on arm64 and ppc64le as PMDK is not well supported. Currently, only 64-bit Linux* and Windows* on x86 are supported PMDK Reference: 1. Experimental support on Arm64, but lacking of librpmem: See: https://github.com/pmem/pmdk#experimental-support-for-64-bit-arm 2. No RPM for PMDK on Arm64: See: https://bugzilla.redhat.com/show_bug.cgi?id=1340635 3. > Does PMDK support ARM64*? > Currently only 64-bit Linux* and Windows* on x86 are supported. See: https://software.intel.com/content/www/us/en/develop/articles/persistent-memory-faq.html 4. Make check fail on Arm64 See: pmem/pmdk#5255 Fixes: https://tracker.ceph.com/issues/51339 Signed-off-by: Kevin Zhao <kevin.zhao@linaro.org>

tchaikov · 2021-06-25T04:02:24Z

this changeset includes #42006

tchaikov · 2021-06-25T05:57:48Z

https://shaman.ceph.com/builds/ceph/wip-kefu-testing2-2021-06-25-1203/743653b645454c0b738cecfb61efcdbe77e667d1/

idryomov · 2021-06-25T10:14:52Z

Disable ppc64 as well as PMDK is only official support on x86

I see the note about AArch64 support being highly experimental (https://github.com/pmem/pmdk/blob/master/README.md#experimental-packages) but nothing about POWER. Can you share a link?

tchaikov · 2021-06-25T11:33:54Z

@idryomov please see the commit message, in which https://software.intel.com/content/www/us/en/develop/articles/persistent-memory-faq.html is referenced. if you search "Does PMDK support ARM64" in that web page, you could find following answer

Currently only 64-bit Linux* and Windows* on x86 are supported.

which is also quoted in the commit message.

idryomov · 2021-06-25T12:31:22Z

Ah, I thought there might be some sort of architecture support status table in the repo going into more detail and didn't realize that that sentence was all there is. I see that a number of test cases are blocklisted on ppc64 though, so it is probably right.

idryomov · 2021-06-25T12:34:38Z

I assume the plan is to merge #42006 and then rebase this PR so that there is only a single commit?

tchaikov · 2021-06-25T13:08:40Z

I assume the plan is to merge #42006 and then rebase this PR so that there is only a single commit?

either way, probably it's simpler to just merge this one so we save a merge commit.

github-actions bot added the build/ops label Jun 24, 2021

kevinzs2048 force-pushed the arm64-rwl-cache-optional branch from c3ff46b to c298dfb Compare June 24, 2021 01:31

tchaikov changed the title ~~pacific: ceph.spec.in: Set rbd-rwl-cache optional on arm64~~ ceph.spec.in: disable rbd-rwl-cache by default on arm64 Jun 24, 2021

kevinzs2048 force-pushed the arm64-rwl-cache-optional branch from c298dfb to 417e97c Compare June 24, 2021 02:05

kevinzs2048 force-pushed the arm64-rwl-cache-optional branch 2 times, most recently from 5161eac to a1c3e81 Compare June 24, 2021 07:15

idryomov added the rbd label Jun 24, 2021

idryomov reviewed Jun 24, 2021

View reviewed changes

ceph.spec.in: enable --with-rbd_ssd_cache by default

3c1cae8

unlike rbd_rwl_cache, rbd_ssd_cache does not depend on pmdk (libpmem), so let's enable it on all supported architecture and rpm based distros. Signed-off-by: Kefu Chai <kchai@redhat.com>

tchaikov previously approved these changes Jun 24, 2021

View reviewed changes

kevinzs2048 force-pushed the arm64-rwl-cache-optional branch from a1c3e81 to 2bcb3bd Compare June 25, 2021 02:57

kevinzs2048 force-pushed the arm64-rwl-cache-optional branch from 16c0843 to 8c7729a Compare June 25, 2021 03:57

kevinzs2048 changed the title ~~ceph.spec.in: disable rbd-rwl-cache by default on arm64~~ ceph.spec.in, debian/rules: disable rbd-rwl-cache by default on arm64 Jun 25, 2021

tchaikov added the arm64 label Jun 25, 2021

tchaikov approved these changes Jun 25, 2021

View reviewed changes

tchaikov added the wip-kefu-testing2 label Jun 25, 2021

tchaikov removed the wip-kefu-testing2 label Jun 25, 2021

tchaikov approved these changes Jun 25, 2021

View reviewed changes

idryomov changed the title ~~ceph.spec.in, debian/rules: disable rbd-rwl-cache by default on arm64~~ ceph.spec.in, debian/rules: enable rbd-rwl-cache by default only on x86_64 Jun 25, 2021

idryomov approved these changes Jun 25, 2021

View reviewed changes

tchaikov merged commit d3d9677 into ceph:master Jun 27, 2021

Conversation

kevinzs2048 commented Jun 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tchaikov commented Jun 24, 2021

Uh oh!

kevinzs2048 commented Jun 24, 2021

Uh oh!

tchaikov commented Jun 24, 2021

Uh oh!

idryomov Jun 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tchaikov Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

tchaikov Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

idryomov Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

tchaikov Jun 24, 2021

Choose a reason for hiding this comment

Uh oh!

kevinzs2048 Jun 25, 2021

Choose a reason for hiding this comment

Uh oh!

idryomov commented Jun 24, 2021

Uh oh!

idryomov commented Jun 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tchaikov commented Jun 24, 2021

Uh oh!

tchaikov commented Jun 25, 2021

Uh oh!

tchaikov commented Jun 25, 2021

Uh oh!

idryomov commented Jun 25, 2021

Uh oh!

tchaikov commented Jun 25, 2021

Uh oh!

idryomov commented Jun 25, 2021

Uh oh!

idryomov commented Jun 25, 2021

Uh oh!

tchaikov commented Jun 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kevinzs2048 commented Jun 24, 2021 •

edited

Loading

idryomov Jun 24, 2021 •

edited

Loading

idryomov commented Jun 24, 2021 •

edited

Loading