cephadm: Set tcmalloc env var for Ceph daemons#42857
Merged
sebastian-philipp merged 1 commit intoceph:masterfrom Aug 24, 2021
Merged
cephadm: Set tcmalloc env var for Ceph daemons#42857sebastian-philipp merged 1 commit intoceph:masterfrom
sebastian-philipp merged 1 commit intoceph:masterfrom
Conversation
We don't need to set the TCMALLOC_MAX_TOTAL_THREAD_CACHE_BYTES environment variable for non Ceph daemons. Fixes: https://tracker.ceph.com/issues/52334 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
sebastian-philipp
approved these changes
Aug 23, 2021
Contributor
sebastian-philipp
left a comment
sebastian-philipp
left a comment
There was a problem hiding this comment.
the lack of any other affected unit tests scares me a bit. Would be great to also have unit tests for the other daemon types as well. Nevertheless, approving it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to set the TCMALLOC_MAX_TOTAL_THREAD_CACHE_BYTES environment
variable for non Ceph daemons.
Fixes: https://tracker.ceph.com/issues/52334
Signed-off-by: Dimitri Savineau dsavinea@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox