Conversation
added 5 commits
April 9, 2015 14:58
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
New images will now default to format 2 RBD images. Fixes: #11348 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Image formats can be explicitly chosen via the --image-format X command-line option. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Override the RBD default image format back to version 1 to ensure tests properly cover the old format. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
please ignore the false negative, network problems |
Member
|
Found the old one I was thinking of: #521 At this point I'm fine with changing the default setting affecting rbd_create() as well. |
jdurgin
added a commit
that referenced
this pull request
Apr 10, 2015
librbd: update default image format to version 2 Reviewed-by: Josh Durgin <jdurgin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.