Skip to content

mgr/dashboard: stabilizing the cephadm dashboard e2e #44428

Merged
alfonsomthd merged 1 commit intoceph:masterfrom
rhcs-dashboard:e2e-improvement
Jan 4, 2022
Merged

mgr/dashboard: stabilizing the cephadm dashboard e2e #44428
alfonsomthd merged 1 commit intoceph:masterfrom
rhcs-dashboard:e2e-improvement

Conversation

@nizamial09
Copy link
Copy Markdown
Member

@nizamial09 nizamial09 commented Dec 30, 2021 •
edited
Loading

Reordering the tests and adding some more tests to verify the cluster is
healthy before proceeding to do some complex tasks like maintenance and
drain host

Fixes: https://tracker.ceph.com/issues/53742
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09 nizamial09 requested a review from a team as a code owner December 30, 2021 08:31
@nizamial09 nizamial09 requested review from aaSharma14 and pereman2 and removed request for a team December 30, 2021 08:31
@nizamial09 nizamial09 removed the pybind label Dec 30, 2021
@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Dec 30, 2021

jenkins test dashboard cephadm

@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Dec 30, 2021

jenkins test dashboard

@nizamial09 nizamial09 changed the title mgr/dashboard: stabilizing the cephadm dashboard e2e mgr/dashboard: stabilizing the cephadm dashboard e2e Dec 30, 2021
@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Dec 30, 2021

jenkins test dashboard cephadm

@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Dec 30, 2021

jenkins test dashboard

@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Dec 31, 2021

jenkins test make check

pereman2
pereman2 reviewed Jan 3, 2022
View reviewed changes
...tend/cypress/integration/orchestrator/workflow/03-create-cluster-create-services.e2e-spec.ts Outdated

it('should edit a service', () => {
const count = '3';
const count = '4';
Copy link
Copy Markdown
Contributor

@pereman2 pereman2 Jan 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why's this?

Copy link
Copy Markdown
Member Author

@nizamial09 nizamial09 Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am making sure all the host has rgw deployed so that when I force maintenance a host, the force maintenance action will behave exactly like it should. (since we are now deploying 4 hosts)

Copy link
Copy Markdown
Contributor

@pereman2 pereman2 Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then should this be hostCount or something like that? Anyways, looks good.

Copy link
Copy Markdown
Member Author

@nizamial09 nizamial09 Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it should be the no. of daemons after service is created and also its called as count in the service placement yaml. That's why I just went for count.

Copy link
Copy Markdown
Contributor

@alfonsomthd alfonsomthd Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more intentional, the better: daemonCount sounds good to me.

Copy link
Copy Markdown
Member Author

@nizamial09 nizamial09 Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pereman2 @alfonsomthd done!

@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Jan 4, 2022

jenkins test dashboard cephadm

@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Jan 4, 2022

jenkins test make check

@alfonsomthd
Copy link
Copy Markdown
Contributor

alfonsomthd commented Jan 4, 2022

jenkins test windows

@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Jan 4, 2022

jenkins test make check

pereman2
pereman2 approved these changes Jan 4, 2022
View reviewed changes
...tend/cypress/integration/orchestrator/workflow/03-create-cluster-create-services.e2e-spec.ts Outdated

it('should edit a service', () => {
const count = '3';
const count = '4';
Copy link
Copy Markdown
Contributor

@pereman2 pereman2 Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then should this be hostCount or something like that? Anyways, looks good.

@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Jan 4, 2022

jenkins test make check

@alfonsomthd
Copy link
Copy Markdown
Contributor

alfonsomthd commented Jan 4, 2022

jenkins test windows

@nizamial09
mgr/dashboard: stabilizing the cephadm dashboard e2e
fbc9f46 
Reordering the tests and adding some more tests to verify the cluster is
healthy before proceeding to do some complex tasks like maintenance and
drain host

Fixes: https://tracker.ceph.com/issues/53742
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Jan 4, 2022

jenkins test make check

@alfonsomthd
Copy link
Copy Markdown
Contributor

alfonsomthd commented Jan 4, 2022

jenkins test windows

@alfonsomthd alfonsomthd merged commit cc63753 into ceph:master Jan 4, 2022
@nizamial09 nizamial09 mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avanthakkar avanthakkar avanthakkar approved these changes

@pereman2 pereman2 pereman2 approved these changes

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14 aaSharma14 was automatically assigned from ceph/dashboard

@epuertat epuertat Awaiting requested review from epuertat

@alfonsomthd alfonsomthd Awaiting requested review from alfonsomthd

+1 more reviewer

@Waadkh7 Waadkh7 Waadkh7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dashboard pybind

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nizamial09 @alfonsomthd @avanthakkar @pereman2 @Waadkh7