Skip to content

quincy: osd: require osd_pg_max_concurrent_snap_trims > 0#45322

Merged
yuriw merged 1 commit intoceph:quincyfrom
ljflores:wip-54467-quincy
Mar 16, 2022
Merged

quincy: osd: require osd_pg_max_concurrent_snap_trims > 0#45322
yuriw merged 1 commit intoceph:quincyfrom
ljflores:wip-54467-quincy

Conversation

@ljflores
Copy link
Copy Markdown
Member

@ljflores ljflores commented Mar 9, 2022

backport tracker: https://tracker.ceph.com/issues/54467


backport of #45140
parent tracker: https://tracker.ceph.com/issues/54396

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

If osd_pg_max_concurrent_snap_trims is zero, we mistakenly clear
the snaptrim queue. Require it to be > 0.

Fixes: https://tracker.ceph.com/issues/54396
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
(cherry picked from commit 29545b6)
@ljflores ljflores added this to the quincy milestone Mar 9, 2022
@ljflores ljflores added the core label Mar 9, 2022
@github-actions github-actions bot added the common label Mar 9, 2022
@ljflores ljflores requested review from neha-ojha and rzarzynski March 9, 2022 16:44
@ljflores ljflores requested a review from dvanders March 9, 2022 17:08
@ljflores
Copy link
Copy Markdown
Member Author

jenkins test windows

@idryomov
Copy link
Copy Markdown
Contributor

jenkins test windows

@yuriw
Copy link
Copy Markdown
Contributor

yuriw commented Mar 16, 2022

@yuriw yuriw merged commit 7d67b17 into ceph:quincy Mar 16, 2022
@ljflores ljflores deleted the wip-54467-quincy branch March 21, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants