quincy: mon, osd: Add snaptrim stats to the existing PG stats.#45524
Merged
yuriw merged 2 commits intoceph:quincyfrom Mar 24, 2022
Merged
quincy: mon, osd: Add snaptrim stats to the existing PG stats.#45524yuriw merged 2 commits intoceph:quincyfrom
yuriw merged 2 commits intoceph:quincyfrom
Conversation
Add a new column, OBJECTS_TRIMMED, to the pg dump stats that shows the number of objects trimmed when a snap is removed. When a pg splits, the stats from the parent pg is copied to the child pg. In such a case, reset objects_trimmed to 0 for the child pg (see PeeringState::split_into()). Otherwise, this will result in incorrect stats to be shown for a child pg after the split operation. Tests: - Librados C and C++ API tests to verify the number of objects trimmed during snaptrim operation. These tests use the self-managed snaps APIs. - Standalone tests to verify objects trimmed using rados pool snaps. Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com> (cherry picked from commit 00249dc)
Add the snaptrim duration to the json formatted output of the pg dump
stats. Define methods for a PG to set the snaptrim begin time and then to
calculate the total time spent to trim all the objects for the snaps in
the snap_trimq for the PG.
Tests:
- Librados C and C++ API tests to verify the time spent for a snaptrim
operation on a PG. These tests use the self-managed snaps APIs.
- Standalone tests to verify snaptrim duration using rados pool snaps.
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit a86ead9)
neha-ojha
approved these changes
Mar 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/54612
backport of #45392
parent tracker: https://tracker.ceph.com/issues/54565
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh