Merged
Conversation
rzarzynski
reviewed
Mar 31, 2022
added 2 commits
March 31, 2022 16:06
If the osd_op failed, still continue to next op when it include CEPH_OSD_OP_FLAG_FAILOK. Signed-off-by: chunmei-liu <chunmei.liu@intel.com>
Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
liu-chunmei
force-pushed
the
crimson-setopflag
branch
from
4ddc327 to
31b6340
Compare
rzarzynski
approved these changes
Apr 1, 2022
Contributor
rzarzynski
left a comment
rzarzynski
left a comment
There was a problem hiding this comment.
LGTM with just one nit.
| do_execute_op(osd_op).handle_error_interruptible( | ||
| crimson::ct_error::eagain::pass_further{}, | ||
| crimson::ct_error::einprogress::pass_further{}, | ||
| osd_op_errorator::all_same_way([] { |
Contributor
There was a problem hiding this comment.
How about using osd_op_errorator::discard_all{} instead of all_same_way?
Contributor
Author
There was a problem hiding this comment.
How about using
osd_op_errorator::discard_all{}instead ofall_same_way?
there is build error, seems discard_call return seastar:future, not consistent with do_execute_op, I can't make a type conversion for discall_all{}. Any suggestion?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows