ceph.spec.in: include SUSE in _with_systemd#4666
Conversation
ghost
added
the
|
Could you add http://tracker.ceph.com/issues/11610 Fixes: #11610 before the Signed-off-by: ? |
|
👍 but Ken is the ultimate authority on these matters. |
The master specfile newly defines a _with_systemd variable that should be true for the set of distros that are using systemd. Since this set of distros includes SUSE/openSUSE (at least for the more recent versions where ceph is supported), this commit sets _with_systemdto true on SUSE/openSUSE. http://tracker.ceph.com/issues/11610 Fixes: ceph#11610 Signed-off-by: Nathan Cutler <ncutler@suse.cz>
|
@dachary: done |
|
Thanks! I was hoping someone would contribute this. Merging... |
ceph.spec.in: include SUSE in _with_systemd Reviewed-by: Loic Dachary <ldachary@redhat.com> Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
|
No idea why github didn't see that this was merged :-( Is it because ncutler@suse.cz isn't associated with your GitHub account? At any rate, it's in master now, as f9d66a8 . Thanks! |
|
Oh shoot, it's because you'd targeted So I think we have to cherry-pick this down to next, now. |
|
@ktdreyer: I targeted next after re-reading the code submission guidelines, which - as I read them - say basically that master is for new features, and use next for everything else. |
|
You were correct to target next. This was my fault. I'll cherry-pick this to next and do a second PR. |
|
cherry-pick to next is at #4670 |
3 participants
http://tracker.ceph.com/issues/11610
The master specfile newly defines a _with_systemd variable that should be true
for the set of distros that are using systemd. Since this set of distros
includes SUSE/openSUSE (at least for the more recent versions where ceph is
supported), this commit sets _with_systemdto true on SUSE/openSUSE.