Normalization of HTTP-X headers should be optional#498
Closed
roaldvanloon wants to merge 1 commit intoceph:masterfrom
Closed
Normalization of HTTP-X headers should be optional#498roaldvanloon wants to merge 1 commit intoceph:masterfrom
roaldvanloon wants to merge 1 commit intoceph:masterfrom
Conversation
Signed-off-by: Roald J. van Loon <roaldvanloon@gmail.com>
Member
|
We should revisit this when looking at the google support. |
mgfritch
added a commit
to mgfritch/ceph
that referenced
this pull request
May 4, 2023
mgr/cephadm: fix backends service in haproxy config with multiple nfs of same rank Reviewed-by: Tim Serong <tserong@suse.com>
tobias-urdin
pushed a commit
to tobias-urdin/ceph
that referenced
this pull request
Aug 2, 2023
QoL: Fix tox.ini syntax and other minor things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a Google Storage API, and while doing that I discovered that all HTTP_X_GOOG_* headers are normalized to x-amz-* entries in the x_meta_map. This breaks the signature checking when authorizing because GS always sends the X-Goog-Api-Version header, which gets normalized to x-amz-api-version and hence become wrongly part of the canonical headers in the authorization signature.
Adding a boolean to the init_meta_info allows to override this default behaviour. It normalizes HTTP_X_GOOG_* header to x-goog-* entries in the x_meta_map.
Signed-off-by: Roald J. van Loon roaldvanloon@gmail.com