mgr/dashboard: add popover to cluster status card#51953
Merged
nizamial09 merged 1 commit intoceph:mainfrom Jun 13, 2023
Merged
Conversation
nizamial09
requested review from
aaSharma14 and
pereman2
and removed request for
a team
Previous dashboard has a popover for the status when there are some warnings in the Cluster Health. Introducing the same behaviour on the new landing page Fixes: https://tracker.ceph.com/issues/61611 Signed-off-by: Nizamudeen A <nia@redhat.com>
nizamial09
force-pushed
the
dashboard-status-popover
branch
from
f8ccaf0 to
947df3d
Compare
pereman2
approved these changes
Jun 7, 2023
aaSharma14
approved these changes
Jun 13, 2023
Contributor
aaSharma14
left a comment
aaSharma14
left a comment
There was a problem hiding this comment.
Thanks @nizamial09 for doing this.
This was referenced Jun 13, 2023
Member
|
@nizamial09 quick suggestion on this, given the amount of whitespace in the status card: what about displaying the health-check alerts as orange labels ( It's not very nice to ask users to click to display alerts, when we have so much empty space there. What do you think? If we don't want to display 1 badge per-health check failure, we could display up to 3 labels with a counter based on alert severity (ok - green, warning - orange, error - red). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous dashboard has a popover for the status when there are some warnings in the Cluster Health. Introducing the same behaviour on the new landing page
Fixes: https://tracker.ceph.com/issues/61611
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows