mgr/dashboard: cluster upgrade progress UI#52919
Merged
nizamial09 merged 1 commit intoceph:mainfrom Aug 15, 2023
Merged
Conversation
avanthakkar
force-pushed
the
cluster-upgrade-progress
branch
2 times, most recently
from
25f134a to
9630958
Compare
Contributor
Author
|
jenkins test make check |
nizamial09
force-pushed
the
cluster-upgrade-progress
branch
2 times, most recently
from
c916ab8 to
e84c569
Compare
nizamial09
requested review from
aaSharma14 and
pereman2
and removed request for
a team
nizamial09
force-pushed
the
cluster-upgrade-progress
branch
3 times, most recently
from
f5b1c07 to
52812f1
Compare
Contributor
|
make check failing with related errors |
nizamial09
force-pushed
the
cluster-upgrade-progress
branch
from
52812f1 to
b2a7d4e
Compare
Fixes: https://tracker.ceph.com/issues/62343 Signed-off-by: avanthakkar <avanjohn@gmail.com> Co-Authored-By: Nizamudeen A <nia@redhat.com>
nizamial09
force-pushed
the
cluster-upgrade-progress
branch
from
b2a7d4e to
3157728
Compare
cloudbehl
approved these changes
Aug 15, 2023
Contributor
There was a problem hiding this comment.
LGTM.
NIT: If I select a New Version from dropdown(18.2.0) and then click image checkbox and put a image. It is still using the new version image which is disabled and not the image I passed.
Could be taken as a bug fix.
Screencast.from.2023-08-15.17-06-22.webm
Member
thanks @cloudbehl will be quick fix. I'll send a PR after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/62343
scrnli_8_11_2023_2-36-15.PM.mp4
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows