osd: fix a missing 'noexcept' on a move ctor #53712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athanatos
reviewed
Sep 28, 2023
src/osd/PG.h
Outdated
| class PGLockWrapper { | ||
| public: | ||
| explicit PGLockWrapper(PGRef locked_pg) : m_pg{locked_pg} {} | ||
| explicit PGLockWrapper(PGRef locked_pg) : m_pg{std::move(locked_pg)} {} |
Contributor
There was a problem hiding this comment.
Probably simpler to template the argument and use std::forward.
Contributor
Author
There was a problem hiding this comment.
Modified as suggested.
ronen-fr
force-pushed
the
wip-rf-move-1
branch
from
4d02634 to
c9d0b59
Compare
athanatos
approved these changes
Nov 7, 2023
Contributor
Author
as a non-default, non-noexcept move ctor is ignored by stl containers. See clang-tidy's performance-noexcept-move-constructor Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
force-pushed
the
wip-rf-move-1
branch
from
c9d0b59 to
084fb34
Compare
Contributor
Author
|
Merging based on Teuthology runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a non-default, non-noexcept move constructor is expected to
be 'noexcept'. Otherwise - it is ignored by stl containers.
See clang-tidy's performance-noexcept-move-constructor