osd/scrub: partial implementation of scrub reserver #55131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronen-fr
force-pushed
the
wip-rf-reserver
branch
2 times, most recently
from
1c1d095 to
1b3875c
Compare
athanatos
approved these changes
Jan 11, 2024
src/osd/scrubber/scrub_machine.h
Outdated
| * - 'cancel' from the primary. We clear our reservation state, and transition | ||
| * back to ReplicaUnreserved. | ||
| * - a chunk request: best response is debateable. For now - we treat that | ||
| * as a cancellation followed by the chunk request. |
Contributor
There was a problem hiding this comment.
I think we should handle the chunk response without affecting the reservation machinery at all. It should be impossible, but it's not a problematic state for the replica so I don't think it's worth adding special code for. It might be worth logging so that teuthology can fail the test, though.
src/osd/scrubber/scrub_resources.h
Outdated
| * | ||
| * - a new reservation request for the same PG: which means we had missed the | ||
| * previous cancellation request. Possible reactions: asserting, or simply | ||
| * removing the previous request from the queue; |
Contributor
There was a problem hiding this comment.
We should cancel the previous one and start the new one. It should also log so that teuthology can fail the test since this should be impossible.
ronen-fr
force-pushed
the
wip-rf-reserver
branch
from
1b3875c to
95f8323
Compare
ronen-fr
force-pushed
the
wip-rf-reserver
branch
2 times, most recently
from
778d173 to
e93f680
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ronen-fr
force-pushed
the
wip-rf-reserver
branch
from
e93f680 to
e5410e9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ronen-fr
force-pushed
the
wip-rf-reserver
branch
from
e5410e9 to
ee4fef3
Compare
ronen-fr
force-pushed
the
wip-rf-reserver
branch
3 times, most recently
from
2b663d8 to
8311289
Compare
To be used when handling replica reservation requests from "old" primaries, that expect an immediate grant/deny reply. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Up-to-date primaries will set this flag when sending a reservation request. The replica OSD, if too busy to handle the request immediately, will queue it until such time that the number of concurrent reservations is below the configured limit. The queued requests are honored in FIFO order. Old primaries will not set this flag, and will receive the expected grant or deny reply immediately. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
The scrub async reserver is not yet used. All requests are treated as 'legacy' requests, i.e. requests that expect an immediate grant/deny reply. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
force-pushed
the
wip-rf-reserver
branch
from
8311289 to
5970ff6
Compare
Contributor
Author
|
jenkins retest this please |
Contributor
Author
|
jenkins test api |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
Merging based on multiple Teuthology runs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial implementation of a change in the way scrub resource reservation
requests (sent by a primary to its replicas) are handled. In the complete implementation,
scrub reservation requests are no longer granted or refused immediately, but rather are queued in an
asynch reserver (similar to the way backfill reservations are handled).
In this partial implementation - all requests are treated as 'legacy', i.e. - the reserver
is never actually used. But the scrubber state-machine is already modified to handle
asynch requests.