Crimson: bump up seastar version by Matan-B · Pull Request #55444 · ceph/ceph

Matan-B · 2024-02-04T10:43:19Z

Update seastar's sub module to: https://github.com/ceph/seastar/commits/seastar-upgrade-feb24/ (patched branch)

Which is using dpdk sub module of: https://github.com/ceph/dpdk/tree/dpdk-seastar-upgrade-feb24 (same as scylladb/seastar)

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

Matan-B · 2024-02-04T11:07:06Z

jenkins retest this please

Matan-B · 2024-02-04T11:49:59Z

jenkins retest this please

Matan-B · 2024-02-04T12:24:21Z

scylladb/seastar#2076 Clang 14 compilation error fix is included in https://github.com/ceph/seastar/commits/seastar-upgrade-feb24/

Matan-B · 2024-02-04T15:07:34Z

https://shaman.ceph.com/builds/ceph/wip-crimson-seastar-upgrade/

https://pulpito.ceph.com/matan-2024-02-04_15:09:23-crimson-rados-wip-crimson-seastar-upgrade-distro-crimson-smithi/

Svelar · 2024-02-05T09:19:18Z

jenkins test make check arm64

Matan-B · 2024-02-05T09:23:02Z

Build and CI are ok but the upgrade exposes runtime issues around alienstore:

DEBUG 2024-02-04 15:35:45,933 [shard 2:main] osd - OSDSingletonState::dispatch_context_transaction: do_transaction ...
DEBUG 2024-02-04 15:35:45,933 [shard 1:main] osd - OSDSingletonState::dispatch_context_transaction: do_transaction ...
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos9/DIST/centos9/MACHINE_SIZE/gigantic/release/19.0.0-1236-g2ddfc3fe/rpm/el9/BUILD/ceph-19.0.0-1236-g2ddfc3fe/redhat-linux-build/boost/include/boost/intrusive/detail/list_node.hpp:66:16: runtime error: member access within null pointer of type 'struct list_node'
Segmentation fault/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos9/DIST/centos9/MACHINE_SIZE/gigantic/release/19.0.0-1236-g2ddfc3fe/rpm/el9/BUILD/ceph-19.0.0-1236-g2ddfc3fe/redhat-linux-build/boost/include/boost/intrusive/detail/list_node.hpp:66:16: runtime error: member access within null pointer of type 'struct list_node'
 on shard 1.
Backtrace:
 2# 0x000056082F3B9503 in ceph-osd
 3# crimson::os::AlienStore::do_transaction_no_callbacks(boost::intrusive_ptr<crimson::os::FuturizedCollection>, ceph::os::Transaction&&) in ceph-osd
 4# 0x00005608273D4EFA in ceph-osd
 5# crimson::osd::ShardServices::dispatch_context_transaction(boost::intrusive_ptr<crimson::os::FuturizedCollection>, PeeringCtx&) in ceph-osd
 6# crimson::osd::ShardServices::dispatch_context(boost::intrusive_ptr<crimson::os::FuturizedCollection>, PeeringCtx&&) in ceph-osd

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

``` # create the directory so cmake won't complain when looking at the imported # target: Seastar exports this directory created at build-time ``` Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Following scylladb/seastar@eea4102 Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Matan-B · 2024-02-06T15:58:59Z

@athanatos, changeset:

d49990f
scylladb/seastar@cc7c8ec was replaced by (merged in seastar) ceph/seastar@3c4582b to allow comilation with clang 14 (used by make check).
The runtime errors were caused due to: gate: add gate holders debugging scylladb/seastar#1329. I have disabled the new debug macro in our sub module and opened a relevant tracker.
ceph/seastar@f3a1484
https://tracker.ceph.com/issues/64332

Tests look ok:
https://pulpito.ceph.com/matan-2024-02-06_13:20:17-crimson-rados-wip-crimson-seastar-upgrade-distro-crimson-smithi/

athanatos · 2024-02-06T23:15:29Z

Yeah, I'm fine with updating the submodule and the fixing the bugs. That should probably be top priority, though.

As PR ceph#55444 update seastar version, the new seastar imports new dependencies, so install seastar dependencies if WITH_SEASTAR is true. Fixes: https://tracker.ceph.com/issues/64420 Signed-off-by: luo rixin <luorixin@huawei.com>

As PR ceph#55444 update seastar version, the new seastar imports new dependencies protobuf. Fixes: https://tracker.ceph.com/issues/64420 Signed-off-by: luo rixin <luorixin@huawei.com>

dmick · 2024-03-14T03:38:22Z

This was not sufficient to handle the runtime dependencies. There is a protobuf package in centos8, but it contains libprotobuf.so.15; building with the packages in this COPR results in a dependency from ceph-osd on libprotobuf.so.30, which can't be satisfied. This will break both the execution of ceph-osd and the building of the centos8 container. See the later comments in https://tracker.ceph.com/issues/64696 (sorry, the bug started describing a separate protobuf issue, but is now the container for the missing runtime dependency).

As PR ceph#55444 update seastar version, the new seastar imports new dependencies protobuf. Fixes: https://tracker.ceph.com/issues/64420 Signed-off-by: luo rixin <luorixin@huawei.com> (cherry picked from commit 450f269)

github-actions bot added build/ops crimson labels Feb 4, 2024

Matan-B force-pushed the wip-crimson-seastar-upgrade branch from 77f6777 to db8433c Compare February 4, 2024 11:01

Matan-B marked this pull request as ready for review February 4, 2024 11:14

Matan-B requested a review from a team as a code owner February 4, 2024 11:14

Matan-B force-pushed the wip-crimson-seastar-upgrade branch 2 times, most recently from 053c24d to 2ddfc3f Compare February 4, 2024 12:09

athanatos approved these changes Feb 4, 2024

View reviewed changes

Matan-B added 4 commits February 6, 2024 15:49

seastar: bump up seastar submodule version

fb802ca

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

CMakeLists.txt: fix Seastar expected dirs

42ead86

``` # create the directory so cmake won't complain when looking at the imported # target: Seastar exports this directory created at build-time ``` Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/crush/CrushLocation: fix compilation errors

40c1978

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

ceph.spec.in: crimson add protobuf

d49990f

Following scylladb/seastar@eea4102 Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Matan-B force-pushed the wip-crimson-seastar-upgrade branch from 2c1a89b to d49990f Compare February 6, 2024 15:53

Matan-B merged commit 31717ac into ceph:main Feb 7, 2024

rosinL mentioned this pull request Feb 18, 2024

debian/control: add new dependencies protobuf for crismon #55632

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crimson: bump up seastar version #55444

Crimson: bump up seastar version #55444
Matan-B merged 4 commits intoceph:mainfrom
Matan-B:wip-crimson-seastar-upgrade

Matan-B commented Feb 4, 2024 •

edited

Loading

Uh oh!

Matan-B commented Feb 4, 2024

Uh oh!

Matan-B commented Feb 4, 2024

Uh oh!

Matan-B commented Feb 4, 2024 •

edited

Loading

Uh oh!

Matan-B commented Feb 4, 2024 •

edited

Loading

Uh oh!

Svelar commented Feb 5, 2024

Uh oh!

Matan-B commented Feb 5, 2024

Uh oh!

Matan-B commented Feb 6, 2024 •

edited

Loading

Uh oh!

athanatos commented Feb 6, 2024

Uh oh!

dmick commented Mar 14, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Matan-B commented Feb 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

Matan-B commented Feb 4, 2024

Uh oh!

Matan-B commented Feb 4, 2024

Uh oh!

Matan-B commented Feb 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Matan-B commented Feb 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Svelar commented Feb 5, 2024

Uh oh!

Matan-B commented Feb 5, 2024

Uh oh!

Matan-B commented Feb 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

athanatos commented Feb 6, 2024

Uh oh!

dmick commented Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Matan-B commented Feb 4, 2024 •

edited

Loading

Matan-B commented Feb 4, 2024 •

edited

Loading

Matan-B commented Feb 4, 2024 •

edited

Loading

Matan-B commented Feb 6, 2024 •

edited

Loading

dmick commented Mar 14, 2024 •

edited

Loading