reef: cephadm: rm podman-auth.json if removing last cluster#56105
Merged
reef: cephadm: rm podman-auth.json if removing last cluster#56105
Conversation
adk3798
commented
Mar 10, 2024
src/cephadm/cephadm.py
Outdated
| for fname in glob(f'{ctx.log_dir}/cephadm.log*'): | ||
| os.remove(fname) | ||
|
|
||
| unlink_file(Path('/etc/ceph/podman-auth.json'), missing_ok=True, ignore_errors=True) |
Contributor
Author
There was a problem hiding this comment.
cephadm.py:8221: error: Name "unlink_file" is not defined
will need to rewrite this bit
Contributor
Author
There was a problem hiding this comment.
Roughly took what the unlink_file function was doing and wrote it here. Not ideal, but we aren't going to end up backporting that change to reef, so this is probably our best option.
We have points in rm-cluster where we check that there are no other clusters on the host. If that is the case, we can also clear /etc/ceph/podman-auth.json which gets written out when we log in to a registry while using podman Fixes: https://tracker.ceph.com/issues/64433 Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit d203a97)
phlogistonjohn
approved these changes
Mar 11, 2024
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
After reruns:
Nothing to block merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/64634
backport of #55588
parent tracker: https://tracker.ceph.com/issues/64433
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh