librbd: diff-iterate shouldn't crash on an empty byte range #57973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A non-empty byte range is required by both last_period_off calculation and Striper::file_to_extents(). Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
14 tasks
Commit 0b5ba5f ("librbd/object_map: add support for ranged diff-iterate") introduced a regression for the case when whole_object parameter is set to true. Despite DiffRequest being called into and another DiffIterate potentially being spawned recursively, an empty byte range previously happened to make it. Bail on an empty byte range early just like we have always done on an empty snap id range (i.e. when start and end versions are the same). Fixes: https://tracker.ceph.com/issues/66418 Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
|
Contributor
Author
|
jenkins test make check |
ajarr
approved these changes
Jun 12, 2024
trociny
approved these changes
Jun 16, 2024
Contributor
Author
This was referenced Jun 23, 2024
Member
|
@idryomov Could this fix https://tracker.ceph.com/issues/68508 ? |
Contributor
Author
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e