squid: osd/scrub: allow new scrubs while reserving#58089
Merged
yuriw merged 2 commits intoceph:squidfrom Jul 9, 2024
Merged
Conversation
allow new scrub session to be initiated by an OSD even while a PG is in the process of reserving scrub resources. The existing restriction made sense when the replica reservation process was expected to succeed or fail within a few milliseconds. It makes less sense now that the reservation process is queue-based (Reserver based) and can take unlimited time (hours, days, ...) to complete. Fixes: https://tracker.ceph.com/issues/66351 Signed-off-by: Ronen Friedman <rfriedma@redhat.com> (cherry picked from commit cca76b0)
As we no longer block the initiation of new scrub sessions for an OSD for which any of its PGs is in the process of reserving scrub resources, there is no need to track the reserving state at the OSD level. Signed-off-by: Ronen Friedman <rfriedma@redhat.com> (cherry picked from commit 1deac15)
athanatos
approved these changes
Jun 17, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow new scrub sessions to be initiated by an OSD even while a PG is
in the process of reserving scrub resources.
The existing restriction made sense when the replica reservation process
was expected to succeed or fail within a few milliseconds. It makes less
sense now that the reservation process is queue-based (Reserver based)
and can take unlimited time (hours, days, ...) to complete.
Backport of #57865
Fixes: https://tracker.ceph.com/issues/66524
Original tracker: https://tracker.ceph.com/issues/66351