Skip to content

Conversation

@badone
Copy link
Contributor

@badone badone commented Jun 24, 2024

IO is frozen when the injectfull command is sent as part of the test which causes the cleanup to hang so we need to clear it.

Fixes: https://tracker.ceph.com/issues/59380

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@badone badone requested a review from a team as a code owner June 24, 2024 02:02
@badone badone added the bug-fix label Jun 24, 2024
@badone badone requested a review from cbodley June 24, 2024 02:03
@cbodley
Copy link
Contributor

cbodley commented Jun 24, 2024

from https://jenkins.ceph.com/job/ceph-api/76404/

dashboard.exceptions.DashboardException: Orchestrator is unavailable

@cbodley
Copy link
Contributor

cbodley commented Jun 24, 2024

jenkins test api

@cbodley
Copy link
Contributor

cbodley commented Jun 24, 2024

from https://jenkins.ceph.com/job/ceph-pull-requests/137451/

The following tests FAILED:
32 - run-rbd-unit-tests-61.sh (Failed)

@cbodley
Copy link
Contributor

cbodley commented Jun 24, 2024

jenkins test make check

@kamoltat
Copy link
Member

kamoltat commented Jun 25, 2024

Came across this PR while scrubbing the main suite tracker issues:

Thank you for addressing this issue, should we approve and move it to QA soon @cbodley?

@cbodley
Copy link
Contributor

cbodley commented Jun 25, 2024

Came across this PR while scrubbing the main suite tracker issues:

Thank you for addressing this issue, should we approve and move it to QA soon @cbodley?

i would prefer not to approve this on behalf of @ceph/core unless i'm really the last resort. maybe @neha-ojha could help review?

p.s. i don't see any reference to https://tracker.ceph.com/issues/59380 in the commit message

@cbodley
Copy link
Contributor

cbodley commented Jun 25, 2024

you might still add the needs-qa label to get tests going in the meantime?

@neha-ojha
Copy link
Member

@badone I am reading https://tracker.ceph.com/issues/59380#note-52, have you already tested this PR? adding needs-qa just in case it needs a larger run

@badone
Copy link
Contributor Author

badone commented Jun 26, 2024

@badone I am reading https://tracker.ceph.com/issues/59380#note-52, have you already tested this PR? adding needs-qa just in case it needs a larger run

Hi @neha-ojha , I have tested it with a standalone run using a modified orig.config.yaml file and it appears to work just fine. I leave it up to you whether it needs wider testing before merging.

IO is frozen when the injectfull command is sent as part of the test
which causes the cleanup to hang so we need to clear it.

Fixes: https://tracker.ceph.com/issues/59380
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone badone force-pushed the wip-tracker-59380-admin-socket-injectfull branch from 2c4b448 to 4c5d0e3 Compare June 26, 2024 00:04
@badone
Copy link
Contributor Author

badone commented Jul 19, 2024

jenkins test api

@ljflores
Copy link
Member

@yuriw yuriw merged commit 4adc795 into ceph:main Jul 23, 2024
@badone badone deleted the wip-tracker-59380-admin-socket-injectfull branch July 23, 2024 22:42
NitzanMordhai pushed a commit to NitzanMordhai/ceph that referenced this pull request Aug 1, 2024
…ket-injectfull

qa/suites/rados: Cancel injectfull to allow cleanup

Reviewed-by: Neha Ojha <nojha@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants