-
Notifications
You must be signed in to change notification settings - Fork 6.3k
qa/suites/rados: Cancel injectfull to allow cleanup #58215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa/suites/rados: Cancel injectfull to allow cleanup #58215
Conversation
|
from https://jenkins.ceph.com/job/ceph-api/76404/
|
|
jenkins test api |
|
from https://jenkins.ceph.com/job/ceph-pull-requests/137451/
|
|
jenkins test make check |
|
Came across this PR while scrubbing the main suite tracker issues: Thank you for addressing this issue, should we approve and move it to QA soon @cbodley? |
i would prefer not to approve this on behalf of @ceph/core unless i'm really the last resort. maybe @neha-ojha could help review? p.s. i don't see any reference to https://tracker.ceph.com/issues/59380 in the commit message |
|
you might still add the |
|
@badone I am reading https://tracker.ceph.com/issues/59380#note-52, have you already tested this PR? adding needs-qa just in case it needs a larger run |
Hi @neha-ojha , I have tested it with a standalone run using a modified orig.config.yaml file and it appears to work just fine. I leave it up to you whether it needs wider testing before merging. |
IO is frozen when the injectfull command is sent as part of the test which causes the cleanup to hang so we need to clear it. Fixes: https://tracker.ceph.com/issues/59380 Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2c4b448 to
4c5d0e3
Compare
|
jenkins test api |
…ket-injectfull qa/suites/rados: Cancel injectfull to allow cleanup Reviewed-by: Neha Ojha <nojha@redhat.com>
IO is frozen when the injectfull command is sent as part of the test which causes the cleanup to hang so we need to clear it.
Fixes: https://tracker.ceph.com/issues/59380
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e