-
Notifications
You must be signed in to change notification settings - Fork 6.3k
cephadm: update shared folder python packages dir #58533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
after centos9 our python version is 3.9 so shouldn't we use the python3.9 path instead of python3.6? Signed-off-by: Nizamudeen A <nia@redhat.com>
|
Seen more instances in But wanted @guits and @tchaikov 's opinion before doing that. |
phlogistonjohn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine. One thing to note is that cephadm can run on a wide variety of distros and python versions so a single python version can never be "right". However, for the one of our most widely used distros for development this is a good update and no worse than before.
|
@adk3798 shall we merge this if the qa run looks okay? |
|
Failures:
Nothing to block merging for all PRs except the one causing the cephadm task failure (not this PR if you see this comment) |
cephadm: update shared folder python packages dir Reviewed-by: Adam King <adking@redhat.com> Reviewed-by: John Mulligan <jmulligan@redhat.com>
|
@nizamial09 should we backport this to squid ? Thanks |
in theory this needs to be backported everywhere where we'll be using centos 9 as the container image base. I know that is the case for squid and also the most recent reef release. I'm unsure when it comes to quincy what the plan is as there was some pushback on the move from centos 8 -> 9 with the most recent reef release. |
@afreen23 we clarified in slack the reason behind the error. At this moment the |
after centos9 our python version is 3.9 so shouldn't we use the python3.9 path instead of python3.6?
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e