Skip to content

Conversation

@cyx1231st
Copy link
Member

@cyx1231st cyx1231st commented Jul 23, 2024

See #56352

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
@cyx1231st cyx1231st requested review from aclamk and rzarzynski July 23, 2024 03:39
@cyx1231st cyx1231st requested a review from a team as a code owner July 23, 2024 03:39
@github-actions github-actions bot added the core label Jul 23, 2024
@cyx1231st cyx1231st requested a review from ifed01 July 23, 2024 03:40
@cyx1231st
Copy link
Member Author

The following tests FAILED:
	  4 - run-tox-mgr (Failed)
	 22 - run-tox-cephadm (Failed)

@cyx1231st
Copy link
Member Author

jenkins test make check

@ifed01 ifed01 merged commit 5d7d1af into ceph:main Jul 23, 2024
@cyx1231st cyx1231st deleted the wip-fix-blk-aio-compile-issue branch July 23, 2024 09:20
NitzanMordhai pushed a commit to NitzanMordhai/ceph that referenced this pull request Aug 1, 2024
…issue

blk/aio: fix compile issue when HAVE_LIBURING isn't defined

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Reviewed-by:  Radoslaw Zarzynski <rzarzyns@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants