quincy: mgr: do not require NOTIFY_TYPES in python modules#59130
quincy: mgr: do not require NOTIFY_TYPES in python modules#59130k0ste wants to merge 1 commit intoceph:quincyfrom
Conversation
Many python mgr modules lack a NOTIFY_TYPES member apparently without any downsides beyond an annoying message in the logs. This includes commonly used mgr modules like 'volumes' and 'cephadm'. Stop emitting an error for missing NOTIFY_TYPES by not assuming all mgr modules in python should provide it. The return code is also changed to indicate that this is not an error but the return from this function is never checked and so it should have no impact. However, if someone started using the return value in the future this would match the log change. Fixes: https://tracker.ceph.com/issues/55835 Signed-off-by: John Mulligan <jmulligan@redhat.com> (cherry picked from commit 4589c4d)
|
jenkins test api |
|
@adk3798 can you approve this, and if we want it in 17.2.8, add "needs-qa" and change it to the 17.2.8 milestone? |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
3 participants
backport tracker: https://tracker.ceph.com/issues/66432
backport of #57106
parent tracker: https://tracker.ceph.com/issues/55835
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh