crimson/common/tri_mutex: also wake up waiters when demoting #59301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into PGRecovery::unfound, instead of heads Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
xxhdx1985126
force-pushed
the
wip-67604
branch
from
bdd1735 to
c9fbace
Compare
Matan-B
reviewed
Aug 19, 2024
xxhdx1985126
force-pushed
the
wip-67604
branch
2 times, most recently
from
82e316d to
a2ddfca
Compare
cyx1231st
reviewed
Aug 20, 2024
xxhdx1985126
force-pushed
the
wip-67604
branch
from
a2ddfca to
872ff63
Compare
athanatos
reviewed
Aug 20, 2024
src/crimson/common/tri_mutex.cc
Outdated
| assert(exclusively_used); | ||
| exclusively_used = false; | ||
| ++readers; | ||
| assert(!writers && !exclusively_used); |
Contributor
There was a problem hiding this comment.
If you move this up one line, it could actually assert !readers as well, I believe.
athanatos
reviewed
Aug 20, 2024
src/crimson/common/tri_mutex.cc
Outdated
| assert(exclusively_used); | ||
| exclusively_used = false; | ||
| ++writers; | ||
| assert(!readers && !exclusively_used); |
athanatos
approved these changes
Aug 20, 2024
Contributor
athanatos
left a comment
athanatos
left a comment
There was a problem hiding this comment.
Other than those nits, I think this is right.
Fixes: https://tracker.ceph.com/issues/67604 Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
xxhdx1985126
force-pushed
the
wip-67604
branch
from
872ff63 to
f956fbc
Compare
Contributor
Author
|
jenkins test api |
cyx1231st
approved these changes
Aug 20, 2024
pritha-srivastava
pushed a commit
to pritha-srivastava/ceph
that referenced
this pull request
Aug 28, 2024
crimson/common/tri_mutex: also wake up waiters when demoting Reviewed-by: Samuel Just <sjust@redhat.com> Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/67604
Signed-off-by: Xuehan Xu xuxuehan@qianxin.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e