rgw: raise default rgw_max_listing_results=5000 #59534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Casey Bodley <cbodley@redhat.com>
allow clients to request more than the default 1000 keys per request bucket listing of large buckets (with many shards) can be more efficient with larger batches. raising max-keys also improves the balls-into-bins algorithm which we artificially cap at a minimum of 8 keys per shard with the default max-keys=1000, we reach this min=8 at around 350 shards. above that shard count, we're always requesting more than the optimal number of entries per shard, so wasting i/o and bandwidth as we raise the max-keys, we push this minimum to higher shard counts: | max-keys | shard count | |----------|-------------| | 1000 | 350 | | 2000 | 720 | | 3000 | 1100 | | 4000 | 1500 | | 5000 | 1900 | this table was calculated with the formula (using various values of max-keys): > solve 8 = 1 + (1000/x + sqrt(2 * 1000 * log10(1000) / x)) ex. https://www.wolframalpha.com/input?i=solve+8+%3D+1+%2B+%281000%2Fx+%2B+sqrt%282+*+1000+*+log10%281000%29+%2F+x%29%29 raising max-keys does increase the total memory usage of each bucket listing request, which gets into megabytes (tens to hundreds?). so i chose 5000 as a cutoff that covers most of the range up to our current rgw_max_dynamic_shards=1999 Signed-off-by: Casey Bodley <cbodley@redhat.com>
dang
approved these changes
Sep 4, 2024
Contributor
|
jenkins test make check |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow clients to request more than the default 1000 keys per request
bucket listing of large buckets (with many shards) can be more efficient with larger batches. raising max-keys also improves the balls-into-bins algorithm (see #30853) which we artificially cap at a minimum of 8 keys per shard
with the default max-keys=1000, we reach this min=8 at around 350 shards. above that shard count, we're always requesting more than the optimal number of entries per shard, so wasting i/o and bandwidth
as we raise the max-keys, we push this minimum to higher shard counts:
this table was calculated with the formula (using various values of max-keys):
ex. https://www.wolframalpha.com/input?i=solve+8+%3D+1+%2B+%281000%2Fx+%2B+sqrt%282+*+1000+*+log10%281000%29+%2F+x%29%29
raising max-keys does increase the total memory usage of each bucket listing request, which gets into megabytes (tens to hundreds?). so i chose 5000 as a cutoff that covers most of the range up to our current rgw_max_dynamic_shards=1999
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e