Skip to content

rpm: Migrate license in ceph.spec to SPDX#59650

Open
xsuchy wants to merge 1 commit intoceph:mainfrom
xsuchy:patch-2
Open

rpm: Migrate license in ceph.spec to SPDX#59650
xsuchy wants to merge 1 commit intoceph:mainfrom
xsuchy:patch-2

Conversation

@xsuchy
Copy link
Copy Markdown

@xsuchy xsuchy commented Sep 7, 2024

All are straightforward but BSD. That should be either 2 or 3 clause. But at least arrow uses both variants.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 6, 2024

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 6, 2024
@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented Nov 6, 2024

If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

I am an author, but I got no feedback. I feel being ignored.

@github-actions github-actions bot removed the stale label Nov 6, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jan 5, 2025
@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented Jan 6, 2025

If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

I am an author and I think this is still appropriate, but I got no feedback. I feel so lonely.

@github-actions github-actions bot removed the stale label Jan 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 7, 2025
@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented Mar 7, 2025

If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

I'd like to ask for a review. But the halls seems to be empty. Only my voice echoes in the empty corridors.

@github-actions github-actions bot removed the stale label Mar 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 6, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label May 6, 2025
@ceph-jenkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented May 6, 2025

Thank you @ceph-jenkins for joining the waiting-for-maintainer force. And hey - @github-actions bot - can you remove the "stale" label? This is still issue is still waiting for a hope.

@github-actions github-actions bot removed the stale label May 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 5, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jul 5, 2025
@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented Jul 5, 2025

Hello stale-bot. It's been a while since we last spoke. Rest assured that I still think it's appropriate, and I would be very happy if a core maintainer could take a look at it.

@github-actions github-actions bot removed the stale label Jul 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 3, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Sep 3, 2025
@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented Sep 4, 2025

How are you doing, stale-bot? I had a great summer. What about you? And yes, thank you for the reminder. I am still interested in this PR; however, I have had a hard time reaching a human. Is this project dead? Or am I invisible? It is nice to chat with you. See you on Oct 5.

@github-actions github-actions bot removed the stale label Sep 4, 2025
@liskin
Copy link
Copy Markdown

liskin commented Sep 5, 2025

Is this project dead?

Doesn't seem to be, about a dozen PRs are merged every day.

Or am I invisible?

That's the more likely explanation. Your PR is just one of 844 open PRs, so you are practically invisible.

It is nice to chat with you. See you on Oct 5.

I was wondering how you were doing. Don't think we've met in a while. Which is largely my fault, having moved to another country. I do meet fellow RedHatters in Ochu whenever I swing by my old hometown, I'm sure I'll bump into you sooner or later.

Oh and apologies if this message of mine disturbs your conversation with stale-bot. I suspect it might delay their visit by a day. Hope you don't mind too much.

Have a great weekend, both of you! 🍻

Copy link
Copy Markdown
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes . you could find more examples with git log ceph.spec.in.

also, could you elaborate on why shall we migrate to SPDX in ceph.spec.in ? see https://github.com/ceph/ceph/blob/main/SubmittingPatches.rst#commit-message . like what's the impact of the change, or what's the problem of staying with the current format.

All are straightforward but BSD. That should be either 2 or 3 clause. But at least arrow uses both variants.

Previous format is non-standard. In Fedora we call it Callaway, because
Tom Callway just made up the IDs.
Fedora is now moving to SPDX as an industry standard.
For more details see https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_4

Signed-off-by: Miroslav Suchý <msuchy@redhat.com>
@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented Sep 8, 2025

could you prefix the title of your commit message with the subcomponent your are changing ?

Done.

also, could you elaborate on why shall we migrate to SPDX in ceph.spec.in ?

Done. Added in commit message. And for reviewer's convenience I will copy it here:

Previous format is non-standard. In Fedora we call it Callaway, because
Tom Callway just made up the IDs.
Fedora is now moving to SPDX as an industry standard.
For more details see https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_4

I rebased the PR.

@xsuchy xsuchy changed the title Migrate license in ceph.spec to SPDX rpm: Migrate license in ceph.spec to SPDX Sep 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 7, 2025

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 7, 2025
@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented Nov 11, 2025

Hi stale-bot. Today I do not have much time. So I will just repeat - yes, I still think the change is appropriate.

@github-actions github-actions bot removed the stale label Nov 11, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Jan 10, 2026
@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented Jan 10, 2026

Hello stale-bot. I wish you a happy New Year. And regarding this issue - yes, it is still valid and I would love to get a review.

@github-actions github-actions bot removed the stale label Jan 10, 2026
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Mar 11, 2026
@xsuchy
Copy link
Copy Markdown
Author

xsuchy commented Mar 12, 2026

Hello stale-bot. So you survived the winter. Glad to hear that. How is your family? What about other developers working with you on this repo? Will they have time to review this one-liner? Or are they busy with gardening in this spring season?

@github-actions github-actions bot removed the stale label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants