Conversation
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
I am an author, but I got no feedback. I feel being ignored. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
I am an author and I think this is still appropriate, but I got no feedback. I feel so lonely. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
I'd like to ask for a review. But the halls seems to be empty. Only my voice echoes in the empty corridors. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
Can one of the admins verify this patch? |
|
Thank you @ceph-jenkins for joining the waiting-for-maintainer force. And hey - @github-actions bot - can you remove the "stale" label? This is still issue is still waiting for a hope. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
Hello stale-bot. It's been a while since we last spoke. Rest assured that I still think it's appropriate, and I would be very happy if a core maintainer could take a look at it. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
How are you doing, stale-bot? I had a great summer. What about you? And yes, thank you for the reminder. I am still interested in this PR; however, I have had a hard time reaching a human. Is this project dead? Or am I invisible? It is nice to chat with you. See you on Oct 5. |
Doesn't seem to be, about a dozen PRs are merged every day.
That's the more likely explanation. Your PR is just one of 844 open PRs, so you are practically invisible.
I was wondering how you were doing. Don't think we've met in a while. Which is largely my fault, having moved to another country. I do meet fellow RedHatters in Ochu whenever I swing by my old hometown, I'm sure I'll bump into you sooner or later. Oh and apologies if this message of mine disturbs your conversation with stale-bot. I suspect it might delay their visit by a day. Hope you don't mind too much. Have a great weekend, both of you! 🍻 |
tchaikov
left a comment
There was a problem hiding this comment.
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes . you could find more examples with git log ceph.spec.in.
also, could you elaborate on why shall we migrate to SPDX in ceph.spec.in ? see https://github.com/ceph/ceph/blob/main/SubmittingPatches.rst#commit-message . like what's the impact of the change, or what's the problem of staying with the current format.
All are straightforward but BSD. That should be either 2 or 3 clause. But at least arrow uses both variants. Previous format is non-standard. In Fedora we call it Callaway, because Tom Callway just made up the IDs. Fedora is now moving to SPDX as an industry standard. For more details see https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_4 Signed-off-by: Miroslav Suchý <msuchy@redhat.com>
Done.
Done. Added in commit message. And for reviewer's convenience I will copy it here: I rebased the PR. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
Hi stale-bot. Today I do not have much time. So I will just repeat - yes, I still think the change is appropriate. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
Hello stale-bot. I wish you a happy New Year. And regarding this issue - yes, it is still valid and I would love to get a review. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
Hello stale-bot. So you survived the winter. Glad to hear that. How is your family? What about other developers working with you on this repo? Will they have time to review this one-liner? Or are they busy with gardening in this spring season? |
All are straightforward but BSD. That should be either 2 or 3 clause. But at least arrow uses both variants.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e