reef: rgw/multisite: metadata polling event based on unmodified mdlog_marker#60793
Merged
reef: rgw/multisite: metadata polling event based on unmodified mdlog_marker#60793
Conversation
Contributor
Author
|
jenkins test api |
Contributor
Author
|
jenkins retest |
adamemerson
approved these changes
Jan 2, 2025
Contributor
Author
|
jenkins test docs |
Contributor
Author
|
jenkins retest |
…ck if the mdlog_marker is not modified by comparing mdlog_marker and max_marker. but max_marker is exposed to changes from RGWReadMDLogEntriesCR, and if there is a race coming from mdlog trimming which could render max_marker empty, then its comparison with mdlog polling can be incorrect. To fix this, we now save the previous mdlog marker and compare with the updated mdlog marker. Signed-off-by: Shilpa Jagannath <smanjara@redhat.com> (cherry picked from commit bae10f2) Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
smanjara
force-pushed
the
wip-69004-reef
branch
from
ebf7726 to
336d040
Compare
Contributor
|
make check |
Contributor
Author
|
jenkins make check |
1 similar comment
Contributor
Author
|
jenkins make check |
Contributor
|
jenkins test make check |
Contributor
|
@smanjara pls merge when all checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/69004
backport of #52568
parent tracker: https://tracker.ceph.com/issues/61743
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh