Skip to content

common/config: make legacy_values static #61025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SrinivasaBharath merged 1 commit into from
Feb 5, 2025
Merged

common/config: make legacy_values static #61025

SrinivasaBharath merged 1 commit into from
Feb 5, 2025

Conversation

@MaxKellermann
Copy link
Member

@MaxKellermann MaxKellermann commented Dec 10, 2024 •
edited
Loading

This field is const and we need only one global instance, and not one copy per md_config_t instance.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)

@MaxKellermann
common/config: make legacy_values static
895691e 
This field is `const` and we need only one global instance, and not
one copy per `md_config_t` instance.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
@rzarzynski rzarzynski requested a review from batrick December 16, 2024 23:44
@MaxKellermann
Copy link
Member Author

MaxKellermann commented Jan 13, 2025

@SrinivasaBharath test results?

@ceph-jenkins
Copy link
Collaborator

ceph-jenkins commented Jan 13, 2025

Can one of the admins verify this patch?

@SrinivasaBharath SrinivasaBharath merged commit 9c12e2d into ceph:main Feb 5, 2025
13 of 14 checks passed
@MaxKellermann MaxKellermann deleted the config_legacy_values__static branch February 5, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@batrick batrick batrick approved these changes

@rzarzynski rzarzynski rzarzynski approved these changes

Assignees

No one assigned

Labels

common core needs-qa wip-bharath12-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MaxKellermann @ceph-jenkins @batrick @rzarzynski @SrinivasaBharath