Skip to content

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Jan 7, 2025


Note:
We could alternatively keep Seastore by default until the missing pieces are there. However, it is probably best to:
a) Not rush delicate changes/features
b) Avoid noise in the suite
c) Avoid "regression" in the default backed used (since thrash tests are supported with Bluestore)

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

This partially reverts f4dee79
Until https://tracker.ceph.com/issues/69402 is resolved.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Seastore supports thrash_simple only until https://tracker.ceph.com/issues/69405
is resolved.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
"basic" directory is included in the non-exp suite and is fully supported

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-seastore-deafult-2 branch from 39da975 to 44e121f Compare January 7, 2025 10:37
As Seastore/trash was removed from the non-exp suite, it is
moved here until fully supported.
Follow-up to: 5150dae

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
This reverts commit 41327dc.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-seastore-deafult-2 branch from 44e121f to de4a2a0 Compare January 7, 2025 10:41
@anthonyeleven
Copy link
Contributor

Is it intentional that this touches 50 files?

Copy link
Member

@cyx1231st cyx1231st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that this touches 50 files?

See the commit message of c202195, LGTM.

@Matan-B
Copy link
Contributor Author

Matan-B commented Jan 8, 2025

@Matan-B Matan-B merged commit ef0dfeb into ceph:main Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged (Pre Tentacle Freeze)

Development

Successfully merging this pull request may close these issues.

5 participants