mgr/cephadm: create OSD daemon deploy specs through make_daemon_spec

[adk3798]

That function handles setting up the extra container/entrypoint args for the daemon during initial deployment. Having the CephadmDaemonDeploySpec made directly in the OSD deployment workflow means initial deployments of OSDs won't have the extra container/entrypoint args from the spec

Fixes: https://tracker.ceph.com/issues/69734

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

• When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows
• jenkins test rook e2e

[phlogistonjohn]

looks ok to me.

[adk3798]

https://pulpito.ceph.com/adking-2025-02-04_14:33:17-orch:cephadm-wip-adk-testing-2025-02-03-2339-distro-default-smithi/

Failures:

• stray daemon and selinux denial failures in SMB tests - known issue
• mds_upgrade_sequence timeout - known issue
• nvmeof tests both failed. This is new and I'll avoid merging nvmeof PRs in the run until I can investigate
• a strange failure in the regular upgrade test where the upgrade seemed to be progressing okay, but was only on the mons when the test decided to check the upgrade was complete, which it wasn't. Hasn't reproduced in reruns and all the other normal upgrade tests passed in the run, so ignoring it for now.

Nothing to block non-NVMEoF related PR

[adk3798]

jenkins test windows