Conversation
Fixes: https://tracker.ceph.com/issues/69858 Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
8c73b64 to
45725fa
Compare
idryomov
left a comment
There was a problem hiding this comment.
I strongly suspect this would fail most Ubuntu-based jobs, same as in RBD: #61689 (comment)
Doesn't this need to be fixed rather than disabled given we should have coverage for ubuntu? The failures are not directly due to the commits in this PR. |
Right, I'm not suggesting continuing to skip valgrind jobs on Ubuntu. I think it does need to be fixed or worked around with a suppression, see more detailed response here: #61689 (comment). |
I see, yes. I appreciate your comments and insights in that case. It seems valgrind is historically problematic on Ubuntu, which seems odd. I guess we could look at alternative coverage using something like libasan? Not a apples for apples replacement but at least some coverage. We could also look at only disabling ubuntu on the valgrind test rather than all the tests in that subsuite using the fragment merging lua scripts, https://docs.ceph.com/projects/teuthology/en/latest/fragment_merging.html |
I don't have the history, but in the quick "smoke" test that I ran on RBD, the (lack of) suppression mentioned in #61689 (comment) appeared to be the only issue. |
I wonder if that sort of issue could be solved by installing the right debuginfo packages? |
|
Setting DNM until I can get to this. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
|
Keeping this on my radar. |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
Fixes: https://tracker.ceph.com/issues/69858
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e