Skip to content

qa: run rados:verify on all distros#61687

Closed
badone wants to merge 1 commit intoceph:mainfrom
badone:wip-remove-centos-only-rados-verify-restriction
Closed

qa: run rados:verify on all distros#61687
badone wants to merge 1 commit intoceph:mainfrom
badone:wip-remove-centos-only-rados-verify-restriction

Conversation

@badone
Copy link
Copy Markdown
Contributor

@badone badone commented Feb 7, 2025

Fixes: https://tracker.ceph.com/issues/69858

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@badone badone requested a review from a team as a code owner February 7, 2025 04:31
Fixes: https://tracker.ceph.com/issues/69858

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
@badone badone force-pushed the wip-remove-centos-only-rados-verify-restriction branch from 8c73b64 to 45725fa Compare February 10, 2025 01:42
Copy link
Copy Markdown
Contributor

@idryomov idryomov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly suspect this would fail most Ubuntu-based jobs, same as in RBD: #61689 (comment)

@badone
Copy link
Copy Markdown
Contributor Author

badone commented Feb 10, 2025

I strongly suspect this would fail most Ubuntu-based jobs, same as in RBD: #61689 (comment)

Doesn't this need to be fixed rather than disabled given we should have coverage for ubuntu? The failures are not directly due to the commits in this PR.

@idryomov
Copy link
Copy Markdown
Contributor

Doesn't this need to be fixed rather than disabled given we should have coverage for ubuntu? The failures are not directly due to the commits in this PR.

Right, I'm not suggesting continuing to skip valgrind jobs on Ubuntu. I think it does need to be fixed or worked around with a suppression, see more detailed response here: #61689 (comment).

@badone
Copy link
Copy Markdown
Contributor Author

badone commented Feb 12, 2025

Doesn't this need to be fixed rather than disabled given we should have coverage for ubuntu? The failures are not directly due to the commits in this PR.

Right, I'm not suggesting continuing to skip valgrind jobs on Ubuntu. I think it does need to be fixed or worked around with a suppression, see more detailed response here: #61689 (comment).

I see, yes. I appreciate your comments and insights in that case. It seems valgrind is historically problematic on Ubuntu, which seems odd. I guess we could look at alternative coverage using something like libasan? Not a apples for apples replacement but at least some coverage. We could also look at only disabling ubuntu on the valgrind test rather than all the tests in that subsuite using the fragment merging lua scripts, https://docs.ceph.com/projects/teuthology/en/latest/fragment_merging.html

@idryomov
Copy link
Copy Markdown
Contributor

I appreciate your comments and insights in that case. It seems valgrind is historically problematic on Ubuntu, which seems odd.

I don't have the history, but in the quick "smoke" test that I ran on RBD, the (lack of) suppression mentioned in #61689 (comment) appeared to be the only issue.

@badone
Copy link
Copy Markdown
Contributor Author

badone commented Feb 13, 2025

I appreciate your comments and insights in that case. It seems valgrind is historically problematic on Ubuntu, which seems odd.

I don't have the history, but in the quick "smoke" test that I ran on RBD, the (lack of) suppression mentioned in #61689 (comment) appeared to be the only issue.

I wonder if that sort of issue could be solved by installing the right debuginfo packages?

@badone badone added the DNM label Mar 21, 2025
@badone
Copy link
Copy Markdown
Contributor Author

badone commented Mar 21, 2025

Setting DNM until I can get to this.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label May 20, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Jun 19, 2025
@badone
Copy link
Copy Markdown
Contributor Author

badone commented Jul 22, 2025

Keeping this on my radar.

@badone badone reopened this Jul 22, 2025
@github-actions github-actions bot removed the stale label Jul 22, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Sep 21, 2025
@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants