tentacle: rgw/lc: stop using merge_and_store_attrs in remove_bucket_config#63075
Merged
cbodley merged 1 commit intoceph:tentaclefrom May 1, 2025
Merged
tentacle: rgw/lc: stop using merge_and_store_attrs in remove_bucket_config#63075cbodley merged 1 commit intoceph:tentaclefrom
cbodley merged 1 commit intoceph:tentaclefrom
Conversation
merge_and_store_attrs() is no longer able to remove xattrs. change the sal::Bucket's attrs manually and call put_info() to write them back Fixes: https://tracker.ceph.com/issues/71083 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit f3cc521)
Contributor
Author
|
needs testing against ceph/s3-tests#645 |
dang
approved these changes
May 1, 2025
Contributor
Author
Collaborator
|
@cbodley is it possible that more work is needed to resolve the issue for v19, or that this got reverted before the v19.2.3 release? We are still seeing that your fix is working in Rook's nightly CI against ceph:main, but we started seeing CI failures consistent with this fix using v19.2.3, opened here: rook/rook#16188 |
Contributor
Author
|
according to https://tracker.ceph.com/issues/71083#note-8 it was the backport of #61995 for 19.2.3. i prepared a squid backport for this fix in #64741 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/71151
backport of #62980
parent tracker: https://tracker.ceph.com/issues/71083
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh