rgw/logging: add size in MPU complete in standard mode#63244
Merged
rgw/logging: add size in MPU complete in standard mode#63244
Conversation
Contributor
Author
|
fix is tested using: ceph/s3-tests#650 |
cbodley
approved these changes
May 20, 2025
src/rgw/rgw_process.cc
Outdated
|
|
||
| if (op) { | ||
| std::ignore = rgw::bucketlogging::log_record(driver, | ||
| if (op && op->get_type() != RGW_OP_COMPLETE_MULTIPART) { |
Contributor
There was a problem hiding this comment.
process_request() should be generic, so special cases for op types here aren't ideal. if we can't come up with a better abstraction to handle this, please at least add a comment why we're skipping for CompleteMultipart
Contributor
Author
There was a problem hiding this comment.
will use the always_log() API that I'm adding in the other PR
14 tasks
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Fixes: https://tracker.ceph.com/issues/71288 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Contributor
Author
|
jenkins test make check |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/71288
Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition