mgr/dashboard: adapt service creation form to support nvmeof creation

[afreen23]

• nvmeof form failing due to absence of pool field in req
• backport of mgr/dashboard: Configure NVMe/TCP #57801

Fixes https://tracker.ceph.com/issues/71340

Before fix:

Screencast.From.2025-05-15.21-57-23.mp4

After fix:

Screencast.From.2025-05-15.21-31-28.mp4

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

• When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins test classic perf Jenkins Job | Jenkins Job Definition
• jenkins test crimson perf Jenkins Job | Jenkins Job Definition
• jenkins test signed Jenkins Job | Jenkins Job Definition
• jenkins test make check Jenkins Job | Jenkins Job Definition
• jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
• jenkins test submodules Jenkins Job | Jenkins Job Definition
• jenkins test dashboard Jenkins Job | Jenkins Job Definition
• jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
• jenkins test api Jenkins Job | Jenkins Job Definition
• jenkins test docs ReadTheDocs | Github Workflow Definition
• jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
• jenkins test windows Jenkins Job | Jenkins Job Definition
• jenkins test rook e2e Jenkins Job | Jenkins Job Definition

[afreen23]

jenkins test api

[nizamial09]

thanks @afreen23

[nizamial09]

make check error, seems familiar

mgr_util.py:27: error: Cannot find implementation or library stub for module named "ceph.deployment.utils"
mgr_util.py:27: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
orchestrator/__init__.py:6: note: In module imported here:
orchestrator/_interface.py:32: error: Cannot find implementation or library stub for module named "ceph.deployment"
orchestrator/_interface.py:33: error: Cannot find implementation or library stub for module named "ceph.deployment.service_spec"
orchestrator/_interface.py:47: error: Cannot find implementation or library stub for module named "ceph.deployment.drive_group"
orchestrator/_interface.py:48: error: Cannot find implementation or library stub for module named "ceph.deployment.hostspec"
orchestrator/_interface.py:49: error: Cannot find implementation or library stub for module named "ceph.utils"
orchestrator/_interface.py: note: In member "__init__" of class "OrchestratorEvent":
orchestrator/_interface.py:1613: error: Incompatible types in assignment (expression has type "Union[str, datetime]", variable has type "datetime")
orchestrator/__init__.py:3: note: In module imported here:
orchestrator/module.py:18: error: Cannot find implementation or library stub for module named "ceph.deployment.inventory"
orchestrator/module.py:19: error: Cannot find implementation or library stub for module named "ceph.deployment.drive_group"
orchestrator/module.py:20: error: Cannot find implementation or library stub for module named "ceph.deployment.service_spec"
orchestrator/module.py:21: error: Cannot find implementation or library stub for module named "ceph.deployment.hostspec"
orchestrator/module.py:22: error: Cannot find implementation or library stub for module named "ceph.deployment.utils"
orchestrator/module.py:23: error: Cannot find implementation or library stub for module named "ceph.utils"
orchestrator/module.py: note: In member "_get_hosts" of class "OrchestratorCli":

[afreen23]

jenkins test make check