tentacle: test/librados/aio_cxx: skip EIO boundary assertion when no in-flight I/Os#64242
Merged
NitzanMordhai merged 2 commits intoceph:tentaclefrom Jul 6, 2025
Merged
Conversation
…I/Os In the PoolEIOFlag test we now track whether any async writes were still in flight at the moment we flipped the pool’s `eio=true` flag using an atomic `missed_eio` flag set inside the helper thread. If we never actually overlapped any in-flight AIOs (we completed all aio successfully) with the flag flip, we `GTEST_SKIP()` the final `max_success+1 == min_failed` boundary assertion, avoiding spurious failures when all writes complete before EIO takes effect. Fixes: https://tracker.ceph.com/issues/70852 Signed-off-by: Nitzan Mordechai <nmordech@redhat.com> (cherry picked from commit 07319d9)
…lEIOFlag GTEST_SKIP() does not return and causes early test exit, which skips any following cleanup logic. In this case, the test skipped before releasing my_lock, causing pthread_mutex_destroy() to fail with EBUSY and trigger a ceph_assert() in the mutex debug wrapper. Fix by explicitly unlocking the mutex before calling GTEST_SKIP(). Signed-off-by: Nitzan Mordechai <nmordech@ibm.com> (cherry picked from commit 26e7bbf)
Matan-B
approved these changes
Jun 29, 2025
Contributor
Matan-B
left a comment
Matan-B
left a comment
There was a problem hiding this comment.
There were no instances of this issue in T, do we still need to backport this? Assuming yes since this test wasn't changed since.
Contributor
Author
right, that PR include both, the test and the fix for the mutex release |
Contributor
Author
Contributor
Author
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/71867
backport of #63177
parent tracker: https://tracker.ceph.com/issues/70852
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh