mgr/smb: Enable per-share profile counters #64254
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoopcs9
approved these changes
Jul 1, 2025
Contributor
anoopcs9
left a comment
anoopcs9
left a comment
There was a problem hiding this comment.
lgtm.
We don't have any tests specific to metrics yet. In that case I hope we can skip adding this new parameter to share configuration from existing test files.
Samba's commit 9f8d272 ("vfs_ceph_new: use per-share profile macros")
enables per-share profile counters for VFS ceph bridge. Enable those by
default for each smb-ceph share.
Signed-off-by: Shachar Sharon <ssharon@redhat.com>
synarete
force-pushed
the
ss-mgr-smb-pershare-profile
branch
from
ff8e777 to
450702a
Compare
Contributor
|
jenkins test make check |
Contributor
|
I am working on doing a teuthology test on three tagged PR, this one included but none of my builds yesterday succeeded. I plan on trying again today. |
Contributor
|
I ran a teuthology test of the smb orch tests and of the two real failures both appeared to be intermittent flakes. No issues related to this change were seen. |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samba's commit 9f8d272 ("vfs_ceph_new: use per-share profile macros") enables per-share profile counters for VFS ceph bridge. Enable those by default for each smb-ceph share.
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition