mgr/dashboard: user accounts enhancements by nmunet · Pull Request #64628 · ceph/ceph

nmunet · 2025-07-23T05:50:53Z

fixes: https://tracker.ceph.com/issues/72072

Before:

The non account root user, doesn't have access to create bucket. We should have a way to assign roles/policies.
In users list page, the root user indication is onhover of Account Name.
In Bucket page, The Owner is shown as account ID if linked with an account

After:

We can now assign managed policies to non-root account users in users form.
In users list page, the root user indication is shifted to username instead of Account Name with a icon.
In Bucket page, The Owner is shown as account name instead of account id & in bucket form the owner is also shown as account name, if bucket linked with an account

Screencast.From.2025-07-22.22-41-44.mp4

Screencast.From.2025-07-24.23-58-59.mp4

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

github-actions · 2025-07-23T05:51:07Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

src/pybind/mgr/dashboard/controllers/rgw.py

src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.html

src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.ts

nizamial09 · 2025-07-24T05:48:48Z

src/pybind/mgr/dashboard/services/rgw_client.py

            raise e

+    def attach_managed_policy(self, userId, policy_arn):
+        radosgw_attach_managed_policies = ['user', 'policy', 'attach',


let's have a tracker to make a switch to the APIs. I think we need to try that again and as per Casey, we have to use the POST req instead of GET call to the iam apis.

yes i will check, https://tracker.ceph.com/issues/72269

src/pybind/mgr/dashboard/services/rgw_client.py

aaSharma14 · 2025-07-24T11:05:41Z

Tested locally, mostly works fine. Thanks @nmunet . Just a couple of comments:

The Account root user icon's tool-tip has a scroll.

Screencast.From.2025-07-24.16-15-14.mp4

Am not sure if this is related to this PR but the User list table is overflowing and the overflow menu which has the action buttons like Edit etc is visible only when we scroll horizontally. Not sure if this is the best practice, ideally actionable should be visible on screen by default. Maybe we can wrap the long usernames.

Screencast.From.2025-07-24.16-21-07.mp4

nmunet · 2025-07-24T18:27:45Z

@aaSharma14 thanks for testing the PR,
the issues mentioned by you is not directly related to this PR.

the issue for scroll is seen in other places also, I will try to fix it in this PR mgr/dashboard: add reusable carbon popover #64388
I agree, the username need to be truncated, will raise a fix for it whenever possible.

nmunet · 2025-07-25T05:19:30Z

jenkins test api

nmunet · 2025-07-25T05:19:58Z

jenkins test dashboard

nmunet · 2025-07-25T05:20:17Z

jenkins test make check arm64

nizamial09

lgtm, thank you @nmunet

src/pybind/mgr/dashboard/controllers/rgw.py

nmunet · 2025-07-25T08:12:30Z

jenkins test dashboard

nmunet · 2025-07-25T08:12:40Z

jenkins test dashboard cephadm

nmunet · 2025-07-25T10:10:34Z

jenkins test api

nmunet · 2025-07-28T05:20:13Z

2025-07-27 15:10:09,027.027 INFO:__main__:---------------------------------------------------------------------- 2025-07-27 15:10:09,028.028 INFO:__main__:Traceback (most recent call last): 2025-07-27 15:10:09,028.028 INFO:__main__: File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/test_rgw.py", line 187, in test_all 2025-07-27 15:10:09,028.028 INFO:__main__: self.assertStatus(200) 2025-07-27 15:10:09,028.028 INFO:__main__: File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/helper.py", line 509, in assertStatus 2025-07-27 15:10:09,028.028 INFO:__main__: self.assertEqual(self._resp.status_code, status) 2025-07-27 15:10:09,028.028 INFO:__main__:AssertionError: 500 != 200

One of the test is failing, can you help fixing this? @nizamial09 @aaSharma14
Also it would be good if any one of you can do another round of testing.

nmunet · 2025-07-29T05:22:51Z

jenkins test windows

cloudbehl · 2025-07-30T08:48:02Z

@nmunet which all forms do you see same bug and can you create tracker for it?

nmunet · 2025-07-30T12:33:26Z

@nmunet which all forms do you see same bug and can you create tracker for it?

https://tracker.ceph.com/issues/72344

dnyanee1997 · 2025-07-30T14:42:34Z

@nmunet , Tested the flow and didn’t find any issues or timeout errors.

Screencast.from.2025-07-30.20-06-02.mp4

nmunet · 2025-07-30T17:16:12Z

@nmunet , Tested the flow and didn’t find any issues or timeout errors.

Screencast.from.2025-07-30.20-06-02.mp4

Thanks for testing it out @dnyanee1997

afreen23 · 2025-07-31T09:10:25Z

jenkins test dashboard

afreen23 · 2025-07-31T09:10:36Z

jenkins test dashboard cephadm

nmunet · 2025-07-31T11:02:44Z

jenkins test dashboard

nmunet · 2025-07-31T11:43:55Z

jenkins test dashboard

nmunet · 2025-08-01T05:47:14Z

jenkins test dashboard

nmunet · 2025-08-01T05:47:27Z

jenkins test dashboard cephadm

cloudbehl

LGTM

nmunet · 2025-08-01T06:29:08Z

jenkins test dashboard

nmunet · 2025-08-01T07:25:27Z

jenkins test dashboard

nmunet · 2025-08-01T10:24:53Z

jenkins test dashboard cephadm

nmunet · 2025-08-01T11:52:24Z

Please don't merge, doing scale testing

dnyanee1997 · 2025-08-01T12:27:07Z

@nmunet , tested the PR with 100 buckets and 100 accounts.

LGTM.
Thanks!

Screencast.from.2025-08-01.17-50-30.mp4

fixes: https://tracker.ceph.com/issues/72072 PR covers: 1) Displaying account name instead of account id in bucket list page & bucket edit form for account owned buckets 2) non-root account user can now be assigned with managed policies with which they can perform operations 3) The root user indication shifted next to username in users list rather than on Account Name with a new icon. Signed-off-by: Naman Munet <naman.munet@ibm.com>

nmunet · 2025-08-01T13:45:28Z

jenkins test make check arm64

nmunet · 2025-08-01T13:50:06Z

jenkins test make check

nmunet · 2025-08-01T13:51:36Z

Thanks @dnyanee1997 for doing the scale testing, I do not see any issue related to timeout here.
I have created a tracker to have skeleton states for accounts table https://tracker.ceph.com/issues/72374

nmunet · 2025-08-03T15:29:09Z

jenkins test make check

nmunet requested a review from a team as a code owner July 23, 2025 05:50

nmunet requested review from abhidesai6 and dnyanee1997 July 23, 2025 05:50

github-actions bot added api-change dashboard pybind labels Jul 23, 2025

github-actions bot added the needs-rebase label Jul 23, 2025

github-project-automation bot added this to Ceph-Dashboard Jul 23, 2025

github-project-automation bot moved this to New in Ceph-Dashboard Jul 23, 2025

nmunet force-pushed the accounts-enhancements branch from af83fcb to 521bef5 Compare July 23, 2025 05:52

github-actions bot removed the needs-rebase label Jul 23, 2025

nizamial09 reviewed Jul 24, 2025

View reviewed changes

aaSharma14 added the ui-tested label Jul 24, 2025

nmunet force-pushed the accounts-enhancements branch from 521bef5 to 792cb84 Compare July 24, 2025 18:14

nizamial09 approved these changes Jul 25, 2025

View reviewed changes

src/pybind/mgr/dashboard/controllers/rgw.py Outdated Show resolved Hide resolved

src/pybind/mgr/dashboard/controllers/rgw.py Outdated Show resolved Hide resolved

github-project-automation bot moved this from New to Reviewer approved in Ceph-Dashboard Jul 25, 2025

nmunet force-pushed the accounts-enhancements branch 2 times, most recently from 897a0af to 8567f2a Compare July 25, 2025 06:53

nmunet force-pushed the accounts-enhancements branch from 8567f2a to 186de69 Compare July 27, 2025 13:51

nmunet force-pushed the accounts-enhancements branch from 186de69 to 1f2fcc9 Compare July 28, 2025 06:13

cloudbehl approved these changes Aug 1, 2025

View reviewed changes

nmunet added the do-not-merge label Aug 1, 2025

dnyanee1997 approved these changes Aug 1, 2025

View reviewed changes

nmunet force-pushed the accounts-enhancements branch from 34f86e7 to 6e9db91 Compare August 1, 2025 12:36

nmunet removed the do-not-merge label Aug 1, 2025

aaSharma14 merged commit e825b4c into ceph:main Aug 5, 2025
14 of 15 checks passed

aaSharma14 deleted the accounts-enhancements branch August 5, 2025 05:32

github-project-automation bot moved this from Reviewer approved to Done in Ceph-Dashboard Aug 5, 2025

nmunet mentioned this pull request Aug 6, 2025

tentacle: mgr/dashboard: user accounts enhancements #64847

Merged

Conversation

nmunet commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Before:

After:

Contribution Guidelines

Checklist

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nizamial09 Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

nmunet Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aaSharma14 commented Jul 24, 2025

Uh oh!

nmunet commented Jul 24, 2025

Uh oh!

nmunet commented Jul 25, 2025

Uh oh!

nmunet commented Jul 25, 2025

Uh oh!

nmunet commented Jul 25, 2025

Uh oh!

nizamial09 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nmunet commented Jul 25, 2025

Uh oh!

nmunet commented Jul 25, 2025

Uh oh!

nmunet commented Jul 25, 2025

Uh oh!

nmunet commented Jul 28, 2025

Uh oh!

nmunet commented Jul 29, 2025

Uh oh!

cloudbehl commented Jul 30, 2025

Uh oh!

nmunet commented Jul 30, 2025

Uh oh!

dnyanee1997 commented Jul 30, 2025

Uh oh!

nmunet commented Jul 30, 2025

Uh oh!

afreen23 commented Jul 31, 2025

Uh oh!

afreen23 commented Jul 31, 2025

Uh oh!

nmunet commented Jul 31, 2025

Uh oh!

nmunet commented Jul 31, 2025

Uh oh!

nmunet commented Aug 1, 2025

Uh oh!

nmunet commented Aug 1, 2025

Uh oh!

cloudbehl left a comment

Choose a reason for hiding this comment

Uh oh!

nmunet commented Aug 1, 2025

Uh oh!

nmunet commented Aug 1, 2025

Uh oh!

nmunet commented Aug 1, 2025

Uh oh!

nmunet commented Aug 1, 2025

Uh oh!

dnyanee1997 commented Aug 1, 2025

Uh oh!

nmunet commented Aug 1, 2025

Uh oh!

nmunet commented Jul 23, 2025 •

edited

Loading