tentacle: test/neorados: Catch timeouts in Poll test#65605
Merged
yuriw merged 1 commit intoceph:tentaclefrom Dec 1, 2025
Merged
tentacle: test/neorados: Catch timeouts in Poll test#65605yuriw merged 1 commit intoceph:tentaclefrom
yuriw merged 1 commit intoceph:tentaclefrom
Conversation
The test is fragile against timing issues which manifest from time to time on Teuthology. Catch the exception and print an error so it's not hidden completely, but stop signaling it as a test failure. I can do something more later, for now just stop having it bother the RADOS team. Fixes: https://tracker.ceph.com/issues/70916 (This time for real!) Signed-off-by: Adam C. Emerson <aemerson@redhat.com> (cherry picked from commit 48b4a75) Conflicts: src/test/neorados/watch_notify.cc - Different timeout value in main from previous failed fix Fixes: https://tracker.ceph.com/issues/70916 Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
rzarzynski
approved these changes
Sep 23, 2025
Contributor
rzarzynski
left a comment
There was a problem hiding this comment.
Generally LGTM. The commit description is a bit weird with the duplicated Fixes and Conflicts. Is that because the patch is being reintroduced?
Contributor
Author
The second |
Contributor
Author
|
@rzarzynski @yuriw Can we get this in a core QA run? |
Contributor
|
@adamemerson Note: no 'tentacle' in the PR name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test is fragile against timing issues which manifest from time to time on Teuthology. Catch the exception and print an error so it's not hidden completely, but stop signaling it as a test failure.
I can do something more later, for now just stop having it bother the RADOS team.
Fixes: https://tracker.ceph.com/issues/70916
(This time for real!)
(cherry picked from commit 48b4a75)
Conflicts:
src/test/neorados/watch_notify.cc
Fixes: https://tracker.ceph.com/issues/70916
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.