Skip to content

tentacle: test/neorados: Catch timeouts in Poll test#65605

Merged
yuriw merged 1 commit intoceph:tentaclefrom
adamemerson:wip-70916-tentacle
Dec 1, 2025
Merged

tentacle: test/neorados: Catch timeouts in Poll test#65605
yuriw merged 1 commit intoceph:tentaclefrom
adamemerson:wip-70916-tentacle

Conversation

@adamemerson
Copy link
Copy Markdown
Contributor

@adamemerson adamemerson commented Sep 19, 2025

The test is fragile against timing issues which manifest from time to time on Teuthology. Catch the exception and print an error so it's not hidden completely, but stop signaling it as a test failure.

I can do something more later, for now just stop having it bother the RADOS team.

Fixes: https://tracker.ceph.com/issues/70916
(This time for real!)

(cherry picked from commit 48b4a75)

Conflicts:
src/test/neorados/watch_notify.cc

  • Different timeout value in main from previous failed fix

Fixes: https://tracker.ceph.com/issues/70916

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

The test is fragile against timing issues which manifest from time to
time on Teuthology. Catch the exception and print an error so it's not
hidden completely, but stop signaling it as a test failure.

I can do something more later, for now just stop having it bother the
RADOS team.

Fixes: https://tracker.ceph.com/issues/70916
(This time for real!)

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 48b4a75)

Conflicts:
	src/test/neorados/watch_notify.cc
 - Different timeout value in main from previous failed fix

Fixes: https://tracker.ceph.com/issues/70916
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
@github-actions github-actions bot added the tests label Sep 19, 2025
@github-actions github-actions bot added this to the tentacle milestone Sep 19, 2025
Copy link
Copy Markdown
Contributor

@rzarzynski rzarzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. The commit description is a bit weird with the duplicated Fixes and Conflicts. Is that because the patch is being reintroduced?

@adamemerson
Copy link
Copy Markdown
Contributor Author

Generally LGTM. The commit description is a bit weird with the duplicated Fixes and Conflicts. Is that because the patch is being reintroduced?

The second Fixes: is for the backport fix. I thought we were supposed to leave the Conflicts: section in when doing a backport if there were merge conflicts?

@adamemerson
Copy link
Copy Markdown
Contributor Author

@rzarzynski @yuriw Can we get this in a core QA run?

@ronen-fr
Copy link
Copy Markdown
Contributor

ronen-fr commented Nov 25, 2025

@adamemerson
RADOS approved. See https://tracker.ceph.com/projects/rados/wiki/TENTACLE#httpstrackercephcomissues73856

Note: no 'tentacle' in the PR name

@adamemerson adamemerson changed the title test/neorados: Catch timeouts in Poll test tentacle: test/neorados: Catch timeouts in Poll test Nov 25, 2025
@yuriw yuriw merged commit 2d71022 into ceph:tentacle Dec 1, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants