Skip to content

mds: Remove unnecessary std::move on trivially-copyable LockOp#65885

Merged
vshankar merged 1 commit intoceph:mainfrom
edwinzrodriguez:ceph-wip-73431
Mar 20, 2026
Merged

mds: Remove unnecessary std::move on trivially-copyable LockOp#65885
vshankar merged 1 commit intoceph:mainfrom
edwinzrodriguez:ceph-wip-73431

Conversation

@edwinzrodriguez
Copy link
Copy Markdown
Contributor

Remove unnecessary std::move on trivially-copyable type LockOp in add_lock method

Fixes: https://tracker.ceph.com/issues/73431

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@github-actions github-actions bot added the cephfs Ceph File System label Oct 10, 2025
@edwinzrodriguez
Copy link
Copy Markdown
Contributor Author

jenkins test make check

@edwinzrodriguez
Copy link
Copy Markdown
Contributor Author

jenkins test all

@edwinzrodriguez
Copy link
Copy Markdown
Contributor Author

jenkins test submodules

@edwinzrodriguez
Copy link
Copy Markdown
Contributor Author

jenkins test docs

@edwinzrodriguez
Copy link
Copy Markdown
Contributor Author

jenkins test docs

1 similar comment
@edwinzrodriguez
Copy link
Copy Markdown
Contributor Author

jenkins test docs

@vshankar
Copy link
Copy Markdown
Contributor

vshankar commented Dec 9, 2025

This PR is under test in https://tracker.ceph.com/issues/74158.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2026

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Feb 7, 2026
@vshankar vshankar removed the stale label Feb 19, 2026
@vshankar
Copy link
Copy Markdown
Contributor

This PR is under test in https://tracker.ceph.com/issues/75027.

Copy link
Copy Markdown
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar
Copy link
Copy Markdown
Contributor

vshankar commented Mar 2, 2026

jenkins test docs

1 similar comment
@vshankar
Copy link
Copy Markdown
Contributor

vshankar commented Mar 2, 2026

jenkins test docs

@vshankar
Copy link
Copy Markdown
Contributor

vshankar commented Mar 3, 2026

jenkins retest this please

@vshankar
Copy link
Copy Markdown
Contributor

vshankar commented Mar 6, 2026

@edwinzrodriguez can you rebase and push please to hopefully get jenkins tests pass?

@vshankar
Copy link
Copy Markdown
Contributor

vshankar commented Mar 9, 2026

jenkins test make check arm64

@vshankar
Copy link
Copy Markdown
Contributor

jenkins test docs

1 similar comment
@vshankar
Copy link
Copy Markdown
Contributor

jenkins test docs

…n add_lock method

Fixes: https://tracker.ceph.com/issues/73431
Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com>
@vshankar
Copy link
Copy Markdown
Contributor

rebase+push to get jenkins tests running to completion.

@vshankar vshankar merged commit 0e59db6 into ceph:main Mar 20, 2026
13 checks passed
@github-actions
Copy link
Copy Markdown

This is an automated message by src/script/redmine-upkeep.py.

I have resolved the following tracker ticket due to the merge of this PR:

No backports are pending for the ticket. If this is incorrect, please update the tracker
ticket and reset to Pending Backport state.

Update Log: https://github.com/ceph/ceph/actions/runs/23329151522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System needs-qa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants