mgr/dashboard: Carbonize the Change Password Form#66006
Conversation
|
Thanks @Afreen, Based on my observation, whenever we click directly on Submit, the field will highlight with an error (red color). It seems to be missing in your PR. |
5b7f236 to
9fc1b7b
Compare
Yes, thats what was the bootstrap behavior. |
|
make check tests failing all over. Recent update: added |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
jenkins test make check |
|
jenkins test make check arm64 |
2 similar comments
|
jenkins test make check arm64 |
|
jenkins test make check arm64 |
...gr/dashboard/frontend/src/app/core/auth/user-password-form/user-password-form.component.html
Show resolved
Hide resolved
...gr/dashboard/frontend/src/app/core/auth/user-password-form/user-password-form.component.html
Outdated
Show resolved
Hide resolved
...gr/dashboard/frontend/src/app/core/auth/user-password-form/user-password-form.component.html
Outdated
Show resolved
Hide resolved
it does though in all our other forms and also in the design.
The missing thing is |
037aeb6 to
32e1221
Compare
32e1221 to
f0d1cb2
Compare
nizamial09
left a comment
There was a problem hiding this comment.
Looks good, thanks @afreen23.
is it just me or is the spacing between navigation sidebar and the page content sort of decreased? or is it the carbon standard? i couldn't find a proper guideline on it.
...gr/dashboard/frontend/src/app/core/auth/user-password-form/user-password-form.component.html
Show resolved
Hide resolved
Fixes https://tracker.ceph.com/issues/73193 - using carbon based stylings, typography and components - used grid layout for form arrangement - breadcrumb is slightly off, which needs to be fixed by applying grid layout to the app shell Signed-off-by: Afreen Misbah <afreen@ibm.com>
f0d1cb2 to
2d43f59
Compare
|
LGTM @afreen23 |
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |



Fixes https://tracker.ceph.com/issues/73193
Also have set the global form css for heading, form items, button as per carbon default:
These are defined in
_forms.scss.Before:
Screencast.From.2025-10-21.22-42-08.mp4
After:
Screencast.From.2025-11-24.14-36-24.mp4
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.