Skip to content

mgr/dashboard: Carbonize the Change Password Form#66006

Merged
afreen23 merged 1 commit intoceph:mainfrom
afreen23:carbonize-chnage-password
Nov 24, 2025
Merged

mgr/dashboard: Carbonize the Change Password Form#66006
afreen23 merged 1 commit intoceph:mainfrom
afreen23:carbonize-chnage-password

Conversation

@afreen23
Copy link
Copy Markdown
Contributor

@afreen23 afreen23 commented Oct 21, 2025

Fixes https://tracker.ceph.com/issues/73193

  • using carbon based stylings, typography and components
  • used grid layout for form arrangement
  • breadcrumb is slightly off, which needs to be fixed by applying grid layout to the app shell

Also have set the global form css for heading, form items, button as per carbon default:

image

These are defined in _forms.scss.

.form-heading {
  h3 {
    @include type.type-style('heading-03');
  }
  display: block;
  margin-bottom: var(--cds-spacing-08);
}

.form-item {
 ...
  margin-bottom: var(--cds-spacing-07);
}

.form-button {
  margin-top: var(--cds-spacing-09);
}

Before:

Screencast.From.2025-10-21.22-42-08.mp4

After:

Screencast.From.2025-11-24.14-36-24.mp4

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

Copy link
Copy Markdown
Contributor

@aaSharma14 aaSharma14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine!

@github-project-automation github-project-automation bot moved this from New to Reviewer approved in Ceph-Dashboard Oct 22, 2025
@dnyanee1997
Copy link
Copy Markdown
Contributor

dnyanee1997 commented Oct 22, 2025

Thanks @Afreen, Based on my observation, whenever we click directly on Submit, the field will highlight with an error (red color). It seems to be missing in your PR.
Screencast From 2025-10-22 17-07-11.webm

@dnyanee1997
Copy link
Copy Markdown
Contributor

Before:
image

After:
image

@afreen23 afreen23 force-pushed the carbonize-chnage-password branch from 5b7f236 to 9fc1b7b Compare October 22, 2025 12:45
@afreen23
Copy link
Copy Markdown
Contributor Author

Thanks @Afreen, Based on my observation, whenever we click directly on Submit, the field will highlight with an error (red color). It seems to be missing in your PR. Screencast From 2025-10-22 17-07-11.webm

Yes, thats what was the bootstrap behavior.
Now its carbonized, so you dont see that, carbon dont have such borders.
Thanks

@afreen23
Copy link
Copy Markdown
Contributor Author

make check tests failing all over.

Recent update: added autofocus for first input field, so that focus comes to first input field once page loads

@afreen23
Copy link
Copy Markdown
Contributor Author

jenkins test make check

@afreen23
Copy link
Copy Markdown
Contributor Author

jenkins test make check arm64

@afreen23
Copy link
Copy Markdown
Contributor Author

jenkins test make check

@afreen23
Copy link
Copy Markdown
Contributor Author

jenkins test make check arm64

2 similar comments
@afreen23
Copy link
Copy Markdown
Contributor Author

jenkins test make check arm64

@afreen23
Copy link
Copy Markdown
Contributor Author

jenkins test make check arm64

@nizamial09
Copy link
Copy Markdown
Member

Now its carbonized, so you dont see that, carbon dont have such borders.

it does though in all our other forms and also in the design.

image

The missing thing is [invalid] attribute for the <input> element

@afreen23 afreen23 force-pushed the carbonize-chnage-password branch 3 times, most recently from 037aeb6 to 32e1221 Compare November 21, 2025 13:16
@afreen23 afreen23 requested a review from nizamial09 November 21, 2025 13:17
@afreen23 afreen23 force-pushed the carbonize-chnage-password branch from 32e1221 to f0d1cb2 Compare November 21, 2025 13:42
Copy link
Copy Markdown
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @afreen23.

is it just me or is the spacing between navigation sidebar and the page content sort of decreased? or is it the carbon standard? i couldn't find a proper guideline on it.

Image

Fixes https://tracker.ceph.com/issues/73193

-  using carbon based stylings, typography and components
-  used grid layout for form arrangement
-  breadcrumb is slightly off, which needs to be fixed by applying grid layout to the app shell

Signed-off-by: Afreen Misbah <afreen@ibm.com>
@afreen23 afreen23 force-pushed the carbonize-chnage-password branch from f0d1cb2 to 2d43f59 Compare November 24, 2025 09:10
@dnyanee1997
Copy link
Copy Markdown
Contributor

LGTM @afreen23
Thanks!

@afreen23
Copy link
Copy Markdown
Contributor Author

jenkins test dashboard

@afreen23
Copy link
Copy Markdown
Contributor Author

jenkins test dashboard cephadm

@afreen23 afreen23 merged commit 005865c into ceph:main Nov 24, 2025
13 of 15 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Ceph-Dashboard Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants