squid: osd/scrub: do not reduce min chunk on preemption#66236
Merged
ronen-fr merged 1 commit intoceph:squidfrom Dec 5, 2025
Merged
squid: osd/scrub: do not reduce min chunk on preemption#66236ronen-fr merged 1 commit intoceph:squidfrom
ronen-fr merged 1 commit intoceph:squidfrom
Conversation
Existing logic handling scrub preemptions is halving both the 'max' and the 'min' values. This isn't optimal: the 'min' values (used mainly to guarantee a minimal number of objects to fetch from the backend in one operation) can and should also be used to limit the effect of preemptions on the execution of the scrub. Fixes: https://tracker.ceph.com/issues/73410 Signed-off-by: Ronen Friedman <rfriedma@redhat.com> (cherry picked from commit 3e8ec7d)
Contributor
Author
|
jenkins test api |
1 similar comment
Contributor
Author
|
jenkins test api |
aclamk
approved these changes
Nov 18, 2025
Contributor
aclamk
left a comment
aclamk
left a comment
There was a problem hiding this comment.
Ok.
Left a note for potential description improvement.
| fmt_desc: The minimal number of object store chunks to scrub during single operation. | ||
| Ceph blocks writes to single chunk during scrub. | ||
| fmt_desc: The minimum number of objects to scrub during single operation. Also | ||
| serves as a minimal chunk size even after scrubbing is preempted by client |
Contributor
There was a problem hiding this comment.
I think "even" here is superfluous.
Contributor
Author
There was a problem hiding this comment.
Maybe (not sure). But as this is a (2'nd) backport - I'll leave it as-is.
rzarzynski
approved these changes
Nov 20, 2025
Contributor
Contributor
Author
|
(sorry - was somehow merged without specifying the reviewers). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing logic handling scrub preemptions is halving both the 'max' and the 'min' values.
This is wrong: the 'min' values (used mainly to guarantee a minimal number of objects to fetch from the backend in one operation) can and should also be used to limit the effect of preemptions on the execution of the scrub.
Backport tracker: https://tracker.ceph.com/issues/73842
'main' tracker: https://tracker.ceph.com/issues/73410
A backport of #65859
(cherry picked from commit 3e8ec7d)