Skip to content

mgr/cephadm: fix nvmeof TLS handling and add coverage for ssl/mTLS#66495

Open
rkachach wants to merge 1 commit intoceph:mainfrom
rkachach:fix_issue_nvmeof_ssl
Open

mgr/cephadm: fix nvmeof TLS handling and add coverage for ssl/mTLS#66495
rkachach wants to merge 1 commit intoceph:mainfrom
rkachach:fix_issue_nvmeof_ssl

Conversation

@rkachach
Copy link
Copy Markdown
Contributor

@rkachach rkachach commented Dec 3, 2025

This PR fixes the value of ssl field on NvmeofServiceSpec (was always set to enable_auth) and add some UT to make sure both specs with ssl only and with mTLS enabled (enable_auth) generate the expected daemon configuration.

Fixes: https://tracker.ceph.com/issues/74073

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

@rkachach rkachach requested a review from a team as a code owner December 3, 2025 09:49
@rkachach rkachach removed the request for review from a team December 3, 2025 09:49
@rkachach
Copy link
Copy Markdown
Contributor Author

rkachach commented Dec 4, 2025

jenkins test submodules

@rkachach
Copy link
Copy Markdown
Contributor Author

rkachach commented Dec 4, 2025

jenkins test api

1 similar comment
@rkachach
Copy link
Copy Markdown
Contributor Author

rkachach commented Dec 4, 2025

jenkins test api

@rkachach rkachach requested review from a team and adk3798 December 4, 2025 14:19
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 2, 2026

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Feb 2, 2026
@rkachach rkachach removed the stale label Feb 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2026

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@rkachach
Copy link
Copy Markdown
Contributor Author

rkachach commented Mar 6, 2026

#66908 already covers this, it just needs proper UT.

@rkachach rkachach force-pushed the fix_issue_nvmeof_ssl branch from bd756f0 to 48d3f96 Compare March 10, 2026 11:17
This PR fixes the value of `ssl` field on `NvmeofServiceSpec` (was
always set to enable_auth) and add some UT to make sure both specs
with ssl only and with mTLS enabled (enable_auth) generate the
expected daemon configuration.

Fixes: https://tracker.ceph.com/issues/74073

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants