mgr/cephadm: fix nvmeof TLS handling and add coverage for ssl/mTLS#66495
mgr/cephadm: fix nvmeof TLS handling and add coverage for ssl/mTLS#66495
Conversation
|
jenkins test submodules |
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
#66908 already covers this, it just needs proper UT. |
bd756f0 to
48d3f96
Compare
This PR fixes the value of `ssl` field on `NvmeofServiceSpec` (was always set to enable_auth) and add some UT to make sure both specs with ssl only and with mTLS enabled (enable_auth) generate the expected daemon configuration. Fixes: https://tracker.ceph.com/issues/74073 Signed-off-by: Redouane Kachach <rkachach@ibm.com>
48d3f96 to
974c5a8
Compare
This PR fixes the value of
sslfield onNvmeofServiceSpec(was always set to enable_auth) and add some UT to make sure both specs with ssl only and with mTLS enabled (enable_auth) generate the expected daemon configuration.Fixes: https://tracker.ceph.com/issues/74073
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.