mgr/dashboard: NVMeoF -Create Gatway group Form by pujaoshahu · Pull Request #66546 · ceph/ceph

pujaoshahu · 2025-12-08T07:12:12Z

Fixes: https://tracker.ceph.com/issues/74134
Signed-off-by: pujaoshahu pshahu@redhat.com

--

Screencast.From.2026-01-27.13-25-40.mp4

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

github-actions · 2025-12-11T18:42:19Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

pujaoshahu · 2026-01-19T07:56:46Z

jenkins test dashboard cephadm

pujaoshahu · 2026-01-19T07:57:21Z

jenkins test api

pujaoshahu · 2026-01-19T07:57:38Z

jenkins test dashboard

pujaoshahu · 2026-01-19T09:42:23Z

jenkins test make check

pujaoshahu · 2026-01-19T09:43:27Z

jenkins test make check arm64

pujaoshahu · 2026-01-19T09:43:36Z

jenkins test dashboard

pujaoshahu · 2026-01-19T09:43:50Z

jenkins test api

pujaoshahu · 2026-01-19T09:44:00Z

jenkins test dashboard cephadm

pujaoshahu · 2026-01-19T13:11:34Z

jenkins test make check

pujaoshahu · 2026-01-19T13:11:41Z

jenkins test make check arm64

pujaoshahu · 2026-01-19T13:11:54Z

jenkins test api

pujaoshahu · 2026-01-19T13:12:04Z

jenkins test dashboard cephadm

pujaoshahu · 2026-01-19T13:12:22Z

jenkins test dashboard

nmunet

Hi @pujaoshahu, some more suggestions from my end

Mostly in forms we keep the buttons in the right side, but its on the left side in this create form.

Also the create gateway group field does not have any validation implemented, i submitted the gateway group name with special characters and the API got failed.

...gr/dashboard/frontend/src/app/ceph/block/nvmeof-group-form /nvmeof-group-form.component.html

github-actions · 2026-01-21T11:06:29Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

pujaoshahu · 2026-01-27T07:54:17Z

Hi @pujaoshahu, some more suggestions from my end

Mostly in forms we keep the buttons in the right side, but its on the left side in this create form. >> As per design its implemented

2. Also the create gateway group field does not have any validation implemented, i submitted the gateway group name with special characters and the API got failed. >>> **Done**

pujaoshahu · 2026-01-27T09:33:13Z

jenkins test make check

pujaoshahu · 2026-01-27T09:33:24Z

jenkins test api

pujaoshahu · 2026-01-27T09:33:40Z

jenkins test dashboard cephadm

nmunet

Thanks @pujaoshahu , LGTM
Also please try to use new control flow blocks @if, @else, @for

.../mgr/dashboard/frontend/src/app/ceph/block/nvmeof-group-form /nvmeof-group-form.component.ts

...shboard/frontend/src/app/ceph/block/nvmeof-gateway-group/nvmeof-gateway-group.component.html

Fixes: https://tracker.ceph.com/issues/74134 Signed-off-by: pujaoshahu <pshahu@redhat.com>

pujaoshahu · 2026-01-28T05:26:35Z

jenkins test make check

pujaoshahu · 2026-01-28T05:27:21Z

jenkins test dashboard

pujaoshahu · 2026-01-28T05:27:33Z

jenkins test dashboard cephadm

github-actions · 2026-01-28T08:00:10Z

This is an automated message by src/script/redmine-upkeep.py.

I found one or more Fixes: tags in the commit messages in

git log bc2e036bb6c163d0acc9085f7bca9ac24c847ca8^..bc2e036bb6c163d0acc9085f7bca9ac24c847ca8

The referenced tickets are:

https://tracker.ceph.com/issues/74134

Those tickets do not reference this merged Pull Request. If this Pull Request merge resolves any of those tickets, please update the "Pull Request ID" field on each ticket. A future run of this script will appropriately update them.

Update Log: https://github.com/ceph/ceph/actions/runs/21429963028

bluikko · 2026-01-28T09:15:17Z

It seems this PR introduced a directory nvmeof-group-form that has a space at the end:
https://github.com/ceph/ceph/tree/main/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-group-form%20

Please note the %20 at the end. Pulling these changes on at least Windows git systems will fail with:

error: invalid path 'src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-group-form /nvmeof-group-form.component.html'

github-actions bot added dashboard pybind labels Dec 8, 2025

github-project-automation bot added this to Ceph-Dashboard Dec 8, 2025

github-project-automation bot moved this to New in Ceph-Dashboard Dec 8, 2025

pujaoshahu force-pushed the create-gateway-group branch 5 times, most recently from 2edf751 to 377eb48 Compare December 11, 2025 07:35

github-actions bot added the needs-rebase label Dec 11, 2025

pujaoshahu force-pushed the create-gateway-group branch from 377eb48 to c0a3c35 Compare December 12, 2025 04:45

github-actions bot removed the needs-rebase label Dec 12, 2025

pujaoshahu force-pushed the create-gateway-group branch 3 times, most recently from 8f70967 to 6975f16 Compare December 15, 2025 17:56

github-actions bot added core tests labels Dec 15, 2025

pujaoshahu force-pushed the create-gateway-group branch 5 times, most recently from bd6fc8e to 6cef167 Compare December 18, 2025 10:40

pujaoshahu force-pushed the create-gateway-group branch 3 times, most recently from 47f4c81 to 3786765 Compare December 23, 2025 05:45

pujaoshahu removed core tests pybind labels Dec 23, 2025

pujaoshahu force-pushed the create-gateway-group branch from 3786765 to 2db9135 Compare December 23, 2025 17:40

nmunet requested changes Jan 20, 2026

View reviewed changes

nmunet approved these changes Jan 27, 2026

View reviewed changes

.../mgr/dashboard/frontend/src/app/ceph/block/nvmeof-group-form /nvmeof-group-form.component.ts Outdated Show resolved Hide resolved

...shboard/frontend/src/app/ceph/block/nvmeof-gateway-group/nvmeof-gateway-group.component.html Outdated Show resolved Hide resolved

mgr/dashboard: NVMeof-Create Gatway group Form

6a0b00c

Fixes: https://tracker.ceph.com/issues/74134 Signed-off-by: pujaoshahu <pshahu@redhat.com>

afreen23 approved these changes Jan 28, 2026

View reviewed changes

bluikko mentioned this pull request Feb 3, 2026

mgr/dashboard: remove trailing space from directory name #67174

Merged

14 tasks

afreen23 mentioned this pull request Mar 3, 2026

tentacle: mgr/dashboard: Batch backport nvmeof revamp #67625

Closed

afreen23 mentioned this pull request Mar 17, 2026

tentacle: mgr/dashboard: Batch backport nvmeof revamp #67839

Open

Conversation

pujaoshahu commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

github-actions bot commented Dec 11, 2025

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

pujaoshahu commented Jan 19, 2026

Uh oh!

nmunet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

pujaoshahu commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pujaoshahu commented Jan 27, 2026

Uh oh!

pujaoshahu commented Jan 27, 2026

Uh oh!

pujaoshahu commented Jan 27, 2026

Uh oh!

nmunet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pujaoshahu commented Jan 28, 2026

Uh oh!

pujaoshahu commented Jan 28, 2026

Uh oh!

pujaoshahu commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

bluikko commented Jan 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pujaoshahu commented Dec 8, 2025 •

edited

Loading

pujaoshahu commented Jan 27, 2026 •

edited

Loading