mon: enable monitor logging by default#67005
Open
indirasawant wants to merge 1 commit intoceph:mainfrom
Open
Conversation
indirasawant
force-pushed
the
wip-isawant-mon-logging
branch
from
5167177 to
fecec75
Compare
| ) | ||
|
|
||
| def should_log_mon_cluster_to_file(ctx: CephadmContext) -> bool: | ||
| if ctx.mon_cluster_log_to_file is not None: |
Contributor
There was a problem hiding this comment.
I am not able to understand why we need this function, ctx.mon_cluster_log_to_file will always be true, right?
Contributor
Author
There was a problem hiding this comment.
Good point. Since the default is always True, I will remove the helper and now use ctx.mon_cluster_log_to_file directly.
indirasawant
force-pushed
the
wip-isawant-mon-logging
branch
2 times, most recently
from
76c7309 to
c7633be
Compare
ShwetaBhosale1
approved these changes
Mar 13, 2026
Contributor
|
jenkins test make check |
Contributor
|
jenkins test make check arm64 |
Contributor
|
jenkins test windows |
| 'ceph', | ||
| '--setgroup', | ||
| 'ceph', | ||
| '--default-log-to-file=false', |
Contributor
There was a problem hiding this comment.
wouldn't removing this make every ceph daemon log to file?
Monitor logs are not written to files by default, which makes debugging and support difficult, especially on collocated nodes where all logs go to journald. Enable file logging by default to ensure monitor logs are always available. Fixes: https://tracker.ceph.com/issues/74473 Signed-off-by: Indira Sawant <indira.sawant@ibm.com>
indirasawant
force-pushed
the
wip-isawant-mon-logging
branch
from
c7633be to
eda4174
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monitor logs are not written to files by default, which makes debugging and support difficult, especially on collocated nodes where all logs go to journald. Enable file logging by default to ensure monitor logs are always available.
Fixes: https://tracker.ceph.com/issues/74473
Signed-off-by: Indira Sawant indira.sawant@ibm.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.