Skip to content

tentacle: mgr/dashboard: fetch all namespaces in a gateway group#67140

Merged
afreen23 merged 2 commits intoceph:tentaclefrom
afreen23:wip-74665-tentacle
Feb 3, 2026
Merged

tentacle: mgr/dashboard: fetch all namespaces in a gateway group#67140
afreen23 merged 2 commits intoceph:tentaclefrom
afreen23:wip-74665-tentacle

Conversation

@afreen23
Copy link
Copy Markdown
Contributor

backport tracker: https://tracker.ceph.com/issues/74665


backport of #67101
parent tracker: https://tracker.ceph.com/issues/74622

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

- adds a new API /api/gateway_group/{group}/namespace
- updates tests
- needed for UI flows and in general to fetch all namespaces, could not change existing API due to the maintenence of backward compatibility
- in a followup PR will add server side pagination

Fixes https://tracker.ceph.com/issues/74622

Signed-off-by: Afreen Misbah <afreen@ibm.com>
(cherry picked from commit b8fef80)
@afreen23
Copy link
Copy Markdown
Contributor Author

afreen23 commented Feb 1, 2026

jenkins test make check

Copy link
Copy Markdown
Contributor

@dnyanee1997 dnyanee1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from New to Reviewer approved in Ceph-Dashboard Feb 2, 2026
@dnyanee1997
Copy link
Copy Markdown
Contributor

jenkins test make check

@Pegonzal
Copy link
Copy Markdown
Contributor

Pegonzal commented Feb 2, 2026

Make check failure: https://jenkins.ceph.com/job/ceph-pull-requests/173650/consoleFull#844925871e840cee4-f4a4-4183-81dd-42855615f2c1

dashboard/controllers/nvmeof.py:424: error: Unexpected keyword argument "server_address" for "NVMeoFClient"  [call-arg]
dashboard/services/nvmeof_client.py:36: note: "NVMeoFClient" defined here

This change is not in tentacle
#66822

@afreen23
Copy link
Copy Markdown
Contributor Author

afreen23 commented Feb 2, 2026

Make check failure: https://jenkins.ceph.com/job/ceph-pull-requests/173650/consoleFull#844925871e840cee4-f4a4-4183-81dd-42855615f2c1

dashboard/controllers/nvmeof.py:424: error: Unexpected keyword argument "server_address" for "NVMeoFClient"  [call-arg]
dashboard/services/nvmeof_client.py:36: note: "NVMeoFClient" defined here

This change is not in tentacle #66822

Ah! Thanks for making life easy here!

- the server_addr is used as traddr
- this change is not backported yet hence ceph#66822 renaming to the convention used in tentacle

Signed-off-by: Afreen Misbah <afreen@ibm.com>
@afreen23
Copy link
Copy Markdown
Contributor Author

afreen23 commented Feb 2, 2026

Update: Added a new commit ea41c29 on top of cherry-pick to revert the name to waht used in tentacle.

Thanks again @Pegonzal it was helpful :) and quick.

@nizamial09
Copy link
Copy Markdown
Member

nizamial09 commented Feb 3, 2026

@Hezko #67004, pointing you here since there will be conflicts depending on which PR goes first..

@afreen23
Copy link
Copy Markdown
Contributor Author

afreen23 commented Feb 3, 2026

@Hezko #67004, pointing you here since there will be conflicts depending on which PR goes first..

Updating here, we decided not go with that PR 67004

@afreen23
Copy link
Copy Markdown
Contributor Author

afreen23 commented Feb 3, 2026

jenkins test api

@afreen23 afreen23 merged commit 83e43bb into ceph:tentacle Feb 3, 2026
14 of 15 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Ceph-Dashboard Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants