tentacle: mgr/dashboard: Fix display of IP address in host page#67146
tentacle: mgr/dashboard: Fix display of IP address in host page#67146afreen23 merged 1 commit intoceph:tentaclefrom
Conversation
afreen23
force-pushed
the
wip-74628-tentacle
branch
from
720971c to
f4bd990
Compare
|
jenkins test make check |
|
Please check - this PR shows 61 file changes, while the original PR had only 4. |
- Hosts data is getting merged with hosts' facts which is not sending address hence not getting displayed in UI - The value is empty hence in the API - Caused by ceph#65102 Fixes https://tracker.ceph.com/issues/74222 Signed-off-by: Afreen Misbah <afreen@ibm.com> (cherry picked from commit 36307be) Conflicts: src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.html
afreen23
force-pushed
the
wip-74628-tentacle
branch
from
f4bd990 to
cc60143
Compare
Thanks, fixed now. |
dnyanee1997
left a comment
dnyanee1997
left a comment
There was a problem hiding this comment.
Why [ngClass] added here. Not seen in original PR
| let-row="data.row"> | ||
| <span [ngClass]="row"> | ||
| <span data-testid="hostname" | ||
| [ngClass]="row"> |
There was a problem hiding this comment.
Why [ngClass] added here. Not seen in original PR
There was a problem hiding this comment.
Its from the existing :) file !
There was a problem hiding this comment.
Not in main
There was a problem hiding this comment.
I think its a non useful discussion, I am not adding this css class, its diff because I have data test-id added.
Its is in the existing file , we should not remove that |
Should we add ngClass in upstream PR- https://github.com/ceph/ceph/pull/66638/changes ? |
I am not understanding here whats the issue ? This is not something I am adding its already there. |
github-project-automation
bot
moved this from New
to Reviewer approved
in Ceph-Dashboard
github-project-automation
bot
moved this from Reviewer approved
to Done
in Ceph-Dashboard
3 participants
backport tracker: https://tracker.ceph.com/issues/74628
backport of #66638
parent tracker: https://tracker.ceph.com/issues/74222
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh