mgr/dashboard: NVMe – Fix host,listeners namespace list display on Subsystem resource page by pujaoshahu · Pull Request #67159 · ceph/ceph

pujaoshahu · 2026-02-02T08:50:24Z

Fixes: https://tracker.ceph.com/issues/74697
Signed-off-by: pujaoshahu pshahu@redhat.com

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

You must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.

github-actions · 2026-02-03T15:22:52Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

afreen23

LGTM , need to be tested

github-actions · 2026-02-11T07:26:46Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

pujaoshahu · 2026-02-23T05:20:06Z

jenkins test make check

pujaoshahu · 2026-02-23T05:20:14Z

jenkins test dashboard cephadm

pujaoshahu · 2026-02-23T05:42:04Z

jenkins test make check arm64

github-actions · 2026-02-23T07:24:57Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

pujaoshahu · 2026-02-23T08:03:14Z

enkins test make check arm64

pujaoshahu · 2026-02-23T08:03:35Z

jenkins test make check arm64

pujaoshahu · 2026-02-23T08:27:32Z

jenkins test make check arm64

pujaoshahu · 2026-02-23T08:45:33Z

jenkins test dashboard cephadm

pujaoshahu · 2026-02-23T08:45:51Z

jenkins test dashboard

pujaoshahu · 2026-02-23T08:49:55Z

jenkins test make check

pujaoshahu · 2026-02-23T09:36:08Z

jenkins test make check arm64

pujaoshahu · 2026-02-23T09:36:24Z

jenkins test api

afreen23 · 2026-02-23T09:54:38Z

Error: src/app/ceph/block/nvmeof-initiators-form/nvmeof-initiators-form.component.ts:8:10 - error TS2300: Duplicate identifier 'Icons'.

8 import { Icons } from '~/app/shared/enum/icons.enum';
           ~~~~~


Error: src/app/ceph/block/nvmeof-initiators-form/nvmeof-initiators-form.component.ts:16:10 - error TS2300: Duplicate identifier 'Icons'.

16 import { Icons } from '~/app/shared/enum/icons.enum';
            ~~~~~


Error: src/app/ceph/block/nvmeof-initiators-form/nvmeof-initiators-form.component.ts:35:3 - error TS2300: Duplicate identifier 'icons'.

35   icons = Icons;
     ~~~~~


Error: src/app/ceph/block/nvmeof-subsystems/nvmeof-subsystems.component.ts:264:11 - error TS6133: 'expandPendingSubsystem' is declared but its value is never read.

264   private expandPendingSubsystem() {

If you run npm run lint you will see error

pujaoshahu · 2026-02-23T10:04:40Z

Error: src/app/ceph/block/nvmeof-initiators-form/nvmeof-initiators-form.component.ts:8:10 - error TS2300: Duplicate identifier 'Icons'.

8 import { Icons } from '~/app/shared/enum/icons.enum';
           ~~~~~


Error: src/app/ceph/block/nvmeof-initiators-form/nvmeof-initiators-form.component.ts:16:10 - error TS2300: Duplicate identifier 'Icons'.

16 import { Icons } from '~/app/shared/enum/icons.enum';
            ~~~~~


Error: src/app/ceph/block/nvmeof-initiators-form/nvmeof-initiators-form.component.ts:35:3 - error TS2300: Duplicate identifier 'icons'.

35   icons = Icons;
     ~~~~~


Error: src/app/ceph/block/nvmeof-subsystems/nvmeof-subsystems.component.ts:264:11 - error TS6133: 'expandPendingSubsystem' is declared but its value is never read.

264   private expandPendingSubsystem() {

If you run npm run lint you will see error

The above error has been resolved, and the test has been retriggered.

pujaoshahu · 2026-02-23T11:30:09Z

jenkins test make check arm64

…bsystem resource page Fixes: https://tracker.ceph.com/issues/74697 Signed-off-by: pujaoshahu <pshahu@redhat.com> Conflicts: src/pybind/mgr/dashboard/frontend/src/app/ceph/block/block.module.ts Signed-off-by: pujaoshahu <pshahu@redhat.com>

afreen23 · 2026-02-24T00:05:11Z

jenkins test make check

pujaoshahu · 2026-02-24T06:10:43Z

jenkins test dashboard

github-actions · 2026-02-24T09:53:38Z

This is an automated message by src/script/redmine-upkeep.py.

I found one or more Fixes: tags in the commit messages in

git log 5daa7e1df83f3db62703ec870f3395da8192342b^..5daa7e1df83f3db62703ec870f3395da8192342b

The referenced tickets are:

https://tracker.ceph.com/issues/74697

Those tickets do not reference this merged Pull Request. If this Pull Request merge resolves any of those tickets, please update the "Pull Request ID" field on each ticket. A future run of this script will appropriately update them.

Update Log: https://github.com/ceph/ceph/actions/runs/22345538623

github-actions bot added dashboard pybind labels Feb 2, 2026

github-project-automation bot added this to Ceph-Dashboard Feb 2, 2026

github-project-automation bot moved this to New in Ceph-Dashboard Feb 2, 2026

pujaoshahu force-pushed the subsystem-host-page branch from 249d788 to 3bc3a74 Compare February 2, 2026 09:19

github-actions bot added the needs-rebase label Feb 3, 2026

pujaoshahu force-pushed the subsystem-host-page branch 2 times, most recently from e12c946 to 67a3727 Compare February 10, 2026 09:08

github-actions bot removed the needs-rebase label Feb 10, 2026

pujaoshahu force-pushed the subsystem-host-page branch 4 times, most recently from 9bc10af to c5d43fd Compare February 10, 2026 15:51

pujaoshahu changed the title ~~mgr/dashboard: NVMe – Fix host list display on Subsystem resource page~~ mgr/dashboard: NVMe – Fix host,listeners namespace list display on Subsystem resource page Feb 10, 2026

pujaoshahu force-pushed the subsystem-host-page branch 2 times, most recently from 3a8f3f4 to 89eb2b8 Compare February 10, 2026 17:49

pujaoshahu marked this pull request as ready for review February 10, 2026 17:50

pujaoshahu requested a review from a team as a code owner February 10, 2026 17:50

pujaoshahu requested review from cloudbehl and nmunet and removed request for cloudbehl February 10, 2026 17:50

pujaoshahu force-pushed the subsystem-host-page branch from 89eb2b8 to cf82ef3 Compare February 11, 2026 07:01

afreen23 approved these changes Feb 11, 2026

View reviewed changes

github-project-automation bot moved this from New to Reviewer approved in Ceph-Dashboard Feb 11, 2026

afreen23 added the need-ui-tested label Feb 11, 2026

github-actions bot added the needs-rebase label Feb 11, 2026

pujaoshahu force-pushed the subsystem-host-page branch from cf82ef3 to 3185640 Compare February 11, 2026 13:16

github-actions bot removed the needs-rebase label Feb 11, 2026

github-actions bot added the needs-rebase label Feb 23, 2026

pujaoshahu force-pushed the subsystem-host-page branch from e82426a to 019447c Compare February 23, 2026 07:27

github-actions bot removed the needs-rebase label Feb 23, 2026

pujaoshahu force-pushed the subsystem-host-page branch from 019447c to f56827e Compare February 23, 2026 10:01

pujaoshahu force-pushed the subsystem-host-page branch from f56827e to e7f15e3 Compare February 23, 2026 11:37

pujaoshahu force-pushed the subsystem-host-page branch from e7f15e3 to 5017783 Compare February 23, 2026 14:47

afreen23 approved these changes Feb 24, 2026

View reviewed changes

github-project-automation bot moved this from Review in progress to Reviewer approved in Ceph-Dashboard Feb 24, 2026

afreen23 merged commit 5daa7e1 into ceph:main Feb 24, 2026
13 of 15 checks passed

afreen23 mentioned this pull request Mar 3, 2026

tentacle: mgr/dashboard: Batch backport nvmeof revamp #67625

Closed

afreen23 mentioned this pull request Mar 17, 2026

tentacle: mgr/dashboard: Batch backport nvmeof revamp #67839

Open

Conversation

pujaoshahu commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

github-actions bot commented Feb 3, 2026

Uh oh!

afreen23 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

afreen23 commented Feb 23, 2026

Uh oh!

pujaoshahu commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pujaoshahu commented Feb 23, 2026

Uh oh!

afreen23 commented Feb 24, 2026

Uh oh!

pujaoshahu commented Feb 24, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pujaoshahu commented Feb 2, 2026 •

edited

Loading

pujaoshahu commented Feb 23, 2026 •

edited

Loading